Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_interface.py

Issue 2175463002: IDL: Support callback interface in overload resolution (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix arg name Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/scripts/v8_interface.py
diff --git a/third_party/WebKit/Source/bindings/scripts/v8_interface.py b/third_party/WebKit/Source/bindings/scripts/v8_interface.py
index 848ef266c6d927760bd1cf7c707eedc4ac602890..1c577d5d14e7e46d68c823a3d082ca73ebf3780e 100644
--- a/third_party/WebKit/Source/bindings/scripts/v8_interface.py
+++ b/third_party/WebKit/Source/bindings/scripts/v8_interface.py
@@ -1107,9 +1107,9 @@ def resolution_tests_methods(effective_overloads):
# Array in overloaded method: http://crbug.com/262383
yield '%s->IsArray()' % cpp_value, method
for idl_type, method in idl_types_methods:
- if idl_type.is_dictionary or idl_type.name == 'Dictionary':
- # FIXME: should be '{1}->IsObject() && !{1}->IsDate() && !{1}->IsRegExp()'.format(cpp_value)
- # FIXME: the IsDate and IsRegExp checks can be skipped if we've
+ if idl_type.is_dictionary or idl_type.name == 'Dictionary' or idl_type.is_callback_interface:
+ # FIXME: should be '{1}->IsObject() && !{1}->IsRegExp()'.format(cpp_value)
+ # FIXME: the IsRegExp checks can be skipped if we've
# already generated tests for them.
yield '%s->IsObject()' % cpp_value, method
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698