Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2175463002: IDL: Support callback interface in overload resolution (Closed)

Created:
4 years, 5 months ago by bashi
Modified:
4 years, 5 months ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IDL: Support callback interface in overload resolution Per the spec[1] we can treat an object as a callback interface if an effective overload set contains the callback interface. [1] http://heycam.github.io/webidl/#es-overloads BUG=629068 Committed: https://crrev.com/d8a924a2dd4693f40a27b33efc2de3db46a2496e Cr-Commit-Position: refs/heads/master@{#407077}

Patch Set 1 #

Patch Set 2 : fix arg name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -3 lines) Patch
M third_party/WebKit/Source/bindings/scripts/v8_interface.py View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 1 2 chunks +61 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
bashi
PTAL
4 years, 5 months ago (2016-07-21 23:14:20 UTC) #6
haraken
LGTM
4 years, 5 months ago (2016-07-22 04:32:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175463002/20001
4 years, 5 months ago (2016-07-22 06:00:17 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-22 06:04:12 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d8a924a2dd4693f40a27b33efc2de3db46a2496e Cr-Commit-Position: refs/heads/master@{#407077}
4 years, 5 months ago (2016-07-22 06:06:05 UTC) #14
Yuki
4 years, 5 months ago (2016-07-22 06:11:56 UTC) #15
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698