Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2175453002:
Roll src/third_party/usrsctp/usrsctplib/ c60ec8b35..9a3e5465e (180 commits). (Closed)
|
Created:
4 years, 5 months ago by Taylor_Brandstetter Modified:
4 years, 4 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll src/third_party/usrsctp/usrsctplib/ c60ec8b35..9a3e5465e (180 commits).
https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/c60ec8b35c3f..9a3e5465e9d9
This roll includes a fix for a crash that was upstreamed:
https://github.com/sctplab/usrsctp/pull/93
Also replacing lally@ with pthatcher@ and deadbeef@ as owners of usrsctp, since Lally is no longer working on Chromium.
BUG=622033
Committed: https://crrev.com/c259443691527968a5bcec022e41844fa606fd7e
Cr-Commit-Position: refs/heads/master@{#409239}
Patch Set 1 #Patch Set 2 : Replacing lally@ with pthacher@ as owner of usrsctp. #Patch Set 3 : Also adding myself as owner as suggested. #Patch Set 4 : Update roll by two more revisions (fixes Windows compilation issue). #Messages
Total messages: 22 (13 generated)
deadbeef@chromium.org changed reviewers: + jiayl@chromium.org, pthatcher@chromium.org
Jiayang, I'm adding you as a reviewer since you're the most relevant remaining owner of third_party/usrsctp, with lally@ gone. Should we update third_party/usrsctp/OWNERS to replace lally@ with pthatcher@?
LGTM
On 2016/07/21 22:39:39, Taylor_Brandstetter wrote: > Jiayang, I'm adding you as a reviewer since you're the most relevant remaining > owner of third_party/usrsctp, with lally@ gone. > > Should we update third_party/usrsctp/OWNERS to replace lally@ with pthatcher@? yes we should
Description was changed from ========== Roll src/third_party/usrsctp/usrsctplib/ c60ec8b35..d94faed08 (178 commits). https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/c6... This roll includes a fix for a crash that was upstreamed: https://github.com/sctplab/usrsctp/pull/93 BUG=622033 ========== to ========== Roll src/third_party/usrsctp/usrsctplib/ c60ec8b35..d94faed08 (178 commits). https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/c6... This roll includes a fix for a crash that was upstreamed: https://github.com/sctplab/usrsctp/pull/93 Also replacing lally@ with pthatcher@ as owner of usrsctp, since lally is no longer at Google. BUG=622033 ==========
Description was changed from ========== Roll src/third_party/usrsctp/usrsctplib/ c60ec8b35..d94faed08 (178 commits). https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/c6... This roll includes a fix for a crash that was upstreamed: https://github.com/sctplab/usrsctp/pull/93 Also replacing lally@ with pthatcher@ as owner of usrsctp, since lally is no longer at Google. BUG=622033 ========== to ========== Roll src/third_party/usrsctp/usrsctplib/ c60ec8b35..d94faed08 (178 commits). https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/c6... This roll includes a fix for a crash that was upstreamed: https://github.com/sctplab/usrsctp/pull/93 Also replacing lally@ with pthatcher@ as owner of usrsctp, since Lally is no longer working on Chromium. BUG=622033 ==========
The CQ bit was checked by deadbeef@chromium.org
The CQ bit was checked by deadbeef@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jiayl@chromium.org Link to the patchset: https://codereview.chromium.org/2175453002/#ps20001 (title: "Replacing lally@ with pthacher@ as owner of usrsctp.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
pthatcher@webrtc.org changed reviewers: + pthatcher@webrtc.org
lgtm You might as well add yourself as an owner. You know that code better than I do at this point.
Description was changed from ========== Roll src/third_party/usrsctp/usrsctplib/ c60ec8b35..d94faed08 (178 commits). https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/c6... This roll includes a fix for a crash that was upstreamed: https://github.com/sctplab/usrsctp/pull/93 Also replacing lally@ with pthatcher@ as owner of usrsctp, since Lally is no longer working on Chromium. BUG=622033 ========== to ========== Roll src/third_party/usrsctp/usrsctplib/ c60ec8b35..9a3e5465e (180 commits). https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/c6... This roll includes a fix for a crash that was upstreamed: https://github.com/sctplab/usrsctp/pull/93 Also replacing lally@ with pthatcher@ and deadbeef@ as owners of usrsctp, since Lally is no longer working on Chromium. BUG=622033 ==========
The CQ bit was checked by deadbeef@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jiayl@chromium.org, pthatcher@webrtc.org Link to the patchset: https://codereview.chromium.org/2175453002/#ps60001 (title: "Update roll by two more revisions (fixes Windows compilation issue).")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from
==========
Roll src/third_party/usrsctp/usrsctplib/ c60ec8b35..9a3e5465e (180 commits).
https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/c6...
This roll includes a fix for a crash that was upstreamed:
https://github.com/sctplab/usrsctp/pull/93
Also replacing lally@ with pthatcher@ and deadbeef@ as owners of usrsctp, since
Lally is no longer working on Chromium.
BUG=622033
==========
to
==========
Roll src/third_party/usrsctp/usrsctplib/ c60ec8b35..9a3e5465e (180 commits).
https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/c6...
This roll includes a fix for a crash that was upstreamed:
https://github.com/sctplab/usrsctp/pull/93
Also replacing lally@ with pthatcher@ and deadbeef@ as owners of usrsctp, since
Lally is no longer working on Chromium.
BUG=622033
==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from
==========
Roll src/third_party/usrsctp/usrsctplib/ c60ec8b35..9a3e5465e (180 commits).
https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/c6...
This roll includes a fix for a crash that was upstreamed:
https://github.com/sctplab/usrsctp/pull/93
Also replacing lally@ with pthatcher@ and deadbeef@ as owners of usrsctp, since
Lally is no longer working on Chromium.
BUG=622033
==========
to
==========
Roll src/third_party/usrsctp/usrsctplib/ c60ec8b35..9a3e5465e (180 commits).
https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/c6...
This roll includes a fix for a crash that was upstreamed:
https://github.com/sctplab/usrsctp/pull/93
Also replacing lally@ with pthatcher@ and deadbeef@ as owners of usrsctp, since
Lally is no longer working on Chromium.
BUG=622033
Committed: https://crrev.com/c259443691527968a5bcec022e41844fa606fd7e
Cr-Commit-Position: refs/heads/master@{#409239}
==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/c259443691527968a5bcec022e41844fa606fd7e Cr-Commit-Position: refs/heads/master@{#409239} |
