Source/web/WebFrameImpl.cpp - Issue 217543005: Move dispatchBeforeUnloadEvent to WebFrame, part 1/3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebFrameImpl.cpp

Issue 217543005: Move dispatchBeforeUnloadEvent to WebFrame, part 1/3. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebFrameImpl.cpp

diff --git a/Source/web/WebFrameImpl.cpp b/Source/web/WebFrameImpl.cpp

index b77f1206377c41769aa70062332ad392838b994e..b94aeae5a34f132a6105fa7f27b09aa4700e78c2 100644

--- a/Source/web/WebFrameImpl.cpp

+++ b/Source/web/WebFrameImpl.cpp

@@ -777,6 +777,14 @@ WebPerformance WebFrameImpl::performance() const

return WebPerformance(&frame()->domWindow()->performance());

}

+bool WebFrameImpl::dispatchBeforeUnloadEvent()

+ if (!frame())

+ return true;

+ return frame()->loader().shouldClose();

abarth-chromium 2014/03/28 22:42:51 You've got an extra blank line here.

Avi (use Gerrit) 2014/03/29 01:30:24 Oops. Fixed.

NPObject* WebFrameImpl::windowObject() const

{

if (!frame())

« no previous file with comments | « Source/web/WebFrameImpl.h ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »