Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 217543005: Move dispatchBeforeUnloadEvent to WebFrame, part 1/3. (Closed)

Created:
6 years, 9 months ago by Avi (use Gerrit)
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move dispatchBeforeUnloadEvent to WebFrame, part 1/3. BUG=357782 TEST=no change Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170407

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M Source/web/WebFrameImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebFrameImpl.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M public/web/WebFrame.h View 1 chunk +7 lines, -0 lines 0 comments Download
M public/web/WebView.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Avi (use Gerrit)
6 years, 9 months ago (2014-03-28 21:45:57 UTC) #1
abarth-chromium
LGTM https://codereview.chromium.org/217543005/diff/1/Source/web/WebFrameImpl.cpp File Source/web/WebFrameImpl.cpp (right): https://codereview.chromium.org/217543005/diff/1/Source/web/WebFrameImpl.cpp#newcode787 Source/web/WebFrameImpl.cpp:787: You've got an extra blank line here.
6 years, 9 months ago (2014-03-28 22:42:51 UTC) #2
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 9 months ago (2014-03-29 01:23:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/217543005/20001
6 years, 9 months ago (2014-03-29 01:24:04 UTC) #4
Avi (use Gerrit)
https://codereview.chromium.org/217543005/diff/1/Source/web/WebFrameImpl.cpp File Source/web/WebFrameImpl.cpp (right): https://codereview.chromium.org/217543005/diff/1/Source/web/WebFrameImpl.cpp#newcode787 Source/web/WebFrameImpl.cpp:787: On 2014/03/28 22:42:51, abarth wrote: > You've got an ...
6 years, 9 months ago (2014-03-29 01:30:24 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-29 02:20:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-29 02:20:59 UTC) #7
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 9 months ago (2014-03-29 03:03:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/217543005/20001
6 years, 9 months ago (2014-03-29 03:05:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/217543005/20001
6 years, 9 months ago (2014-03-29 03:05:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/217543005/20001
6 years, 9 months ago (2014-03-29 03:06:28 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-29 04:09:22 UTC) #12
Message was sent while issue was closed. 
Change committed as 170407

Powered by Google App Engine
This is Rietveld 408576698