tools/grit/grit_rule.gni - Issue 2175413004: Enable whitelist generation for all builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/grit/grit_rule.gni

Issue 2175413004: Enable whitelist generation for all builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Enable whitelist generation for official builds. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/grit/grit_rule.gni

diff --git a/tools/grit/grit_rule.gni b/tools/grit/grit_rule.gni

index b77a24d5e6fb3f2f429bb47c8f71fcea2941774e..ebb6cb44426cf424fb4da96095ed6ccf005b4c0a 100644

--- a/tools/grit/grit_rule.gni

+++ b/tools/grit/grit_rule.gni

@@ -84,8 +84,11 @@ import("//build/config/features.gni")

import("//build/config/ui.gni")

declare_args() {

- # Enables used resource whitelist generation.

- enable_resource_whitelist_generation = false

+ # Enables used resource whitelist generation. Set for official builds only

+ # as a large amount of build output is generated.

+ enable_resource_whitelist_generation = is_android && is_official_build

+ assert(!enable_resource_whitelist_generation || is_android,

+ "resource whitelist generation only works on android")

Dirk Pranke 2016/08/03 00:59:07 The assert should be outside of the declare_args()

estevenson 2016/08/03 13:51:14 Done.

}

grit_defines = []

« no previous file with comments | « tools/grit/grit/format/repack.py ('k') | tools/grit/repack.gni » ('j') | no next file with comments »