Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: tools/grit/grit_rule.gni

Issue 2175413004: Enable whitelist generation for all builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Enable whitelist generation for official builds. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/grit/grit/format/repack.py ('k') | tools/grit/repack.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/grit/grit_rule.gni
diff --git a/tools/grit/grit_rule.gni b/tools/grit/grit_rule.gni
index b77a24d5e6fb3f2f429bb47c8f71fcea2941774e..6ecadd5718a35e8e5cbd18fac8afa9f2bb269728 100644
--- a/tools/grit/grit_rule.gni
+++ b/tools/grit/grit_rule.gni
@@ -84,8 +84,13 @@ import("//build/config/features.gni")
import("//build/config/ui.gni")
declare_args() {
- # Enables used resource whitelist generation.
- enable_resource_whitelist_generation = false
+ # Enables used resource whitelist generation. Set for official builds only
+ # as a large amount of build output is generated.
+ enable_resource_whitelist_generation = is_official_build
Dirk Pranke 2016/07/30 00:14:51 This should default to (is_android && is_offical_b
estevenson 2016/08/02 14:52:54 Done.
+ if (!is_android && enable_resource_whitelist_generation) {
+ print(
+ "Warning: GN logic for resource whitelists is implemented only for Android")
+ }
Dirk Pranke 2016/07/30 00:14:51 Can you make this: assert(!enable_resource_whitel
estevenson 2016/08/02 14:52:54 Done.
}
grit_defines = []
« no previous file with comments | « tools/grit/grit/format/repack.py ('k') | tools/grit/repack.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698