Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: tools/grit/grit_rule.gni

Issue 2175413004: Enable whitelist generation for all builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed agrieve's comments and removed stderr filtering. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/grit/grit_rule.gni
diff --git a/tools/grit/grit_rule.gni b/tools/grit/grit_rule.gni
index b77a24d5e6fb3f2f429bb47c8f71fcea2941774e..6ecadd5718a35e8e5cbd18fac8afa9f2bb269728 100644
--- a/tools/grit/grit_rule.gni
+++ b/tools/grit/grit_rule.gni
@@ -84,8 +84,13 @@ import("//build/config/features.gni")
import("//build/config/ui.gni")
declare_args() {
- # Enables used resource whitelist generation.
- enable_resource_whitelist_generation = false
+ # Enables used resource whitelist generation. Set for official builds only
+ # as a large amount of build output is generated.
+ enable_resource_whitelist_generation = is_official_build
+ if (!is_android && enable_resource_whitelist_generation) {
+ print(
+ "Warning: GN logic for resource whitelists is implemented only for Android")
+ }
}
grit_defines = []

Powered by Google App Engine
This is Rietveld 408576698