chrome/chrome_repack_locales.gni - Issue 2175413004: Enable whitelist generation for all builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_repack_locales.gni

Issue 2175413004: Enable whitelist generation for all builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed agrieve's comments and removed stderr filtering. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/chrome_repack_locales.gni

diff --git a/chrome/chrome_repack_locales.gni b/chrome/chrome_repack_locales.gni

index 83b1e19a33b50508ba4a33351b54c895212ab906..d67cc19fb39568cf43f6c7e7560f531bac2c93ea 100644

--- a/chrome/chrome_repack_locales.gni

+++ b/chrome/chrome_repack_locales.gni

@@ -6,6 +6,7 @@ import("//build/config/chrome_build.gni")

import("//build/config/features.gni")

import("//build/config/ui.gni")

import("//tools/grit/repack.gni")

+import("//tools/grit/grit_rule.gni")

# Arguments:

@@ -118,6 +119,10 @@ template("_repack_one_locale") {

]

}

+ if (is_android && enable_resource_whitelist_generation) {

+ repack_whitelist = "$target_gen_dir/resource_whitelist.txt"

+ deps += [ "//chrome:resource_whitelist" ]

+ }

output = invoker.output

}