Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2175403002: [Cronet] Mark request as complete when OutputStream fails (Closed)

Created:
4 years, 4 months ago by xunjieli
Modified:
4 years, 4 months ago
Reviewers:
pauljensen
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Cronet] Mark request as complete when OutputStream fails When consumer specifies a chunked upload or a fixed stream upload, Cronet's HttpURLConnection starts the request right away. If an error happens, we will surface that error as an IOException to consumer. However, if the consumer tries to call any other API (like getResponseCode(), getResponseMessage()) afterwards, we will spin up the message loop and wait forever. This CL marks the request as complete if an error occurred in upload, so getResponseCode() etc. do not spin up the message loop to wait for response. TBR=pauljensen@chromium.org NOTRY=true NOPRESUBMIT=true BUG=630664 Review-Url: https://codereview.chromium.org/2173923002 Cr-Commit-Position: refs/heads/master@{#407468} (cherry picked from commit 7fbfe4fe8ff451d1f65ac574a2304d383aaeec16)

Patch Set 1 #

Messages

Total messages: 5 (1 generated)
xunjieli
Paul, I am TBR-ing you. I will CQ it once I confirm that Cronet tests ...
4 years, 4 months ago (2016-07-25 18:02:27 UTC) #1
xunjieli
On 2016/07/25 18:02:27, xunjieli wrote: > Paul, I am TBR-ing you. I will CQ it ...
4 years, 4 months ago (2016-07-25 18:28:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175403002/1
4 years, 4 months ago (2016-07-25 18:29:03 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-07-25 18:33:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698