Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2175383003: [system-health] Fix mobile facebook story for Nexus7v2. (Closed)

Created:
4 years, 5 months ago by ulan
Modified:
4 years, 4 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org, petrcermak
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[system-health] Fix mobile facebook story for Nexus7v2. Facebook fetches items on demand while scrolling. Before this patch Nexus7v2 was timing out while waiting for items because the scroll distance was not enough to trigger fetching of items. This patch increases the scroll distance and updates WPR. *** NOTE TO SHERRIF *** Regressions are expected in browse:social:facebook story. BUG=631022 Committed: https://crrev.com/aa939aefe4a8f0c33705ed006bcab8bf13134820 Cr-Commit-Position: refs/heads/master@{#407756}

Patch Set 1 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M tools/perf/page_sets/data/system_health_mobile.json View 1 chunk +3 lines, -3 lines 0 comments Download
A tools/perf/page_sets/data/system_health_mobile_028.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/system_health/browsing_stories.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ulan
ptal
4 years, 5 months ago (2016-07-25 19:47:17 UTC) #4
nednguyen
lgtm
4 years, 5 months ago (2016-07-25 23:14:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175383003/40001
4 years, 4 months ago (2016-07-26 08:13:01 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 4 months ago (2016-07-26 10:06:59 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 10:08:57 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa939aefe4a8f0c33705ed006bcab8bf13134820
Cr-Commit-Position: refs/heads/master@{#407756}

Powered by Google App Engine
This is Rietveld 408576698