Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2175373003: exo: Convert initial bounds to screen coordinates (Closed)

Created:
4 years, 5 months ago by Dominik Laskowski
Modified:
4 years, 4 months ago
Reviewers:
reveman, oshima
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Convert initial bounds to screen coordinates Since the initial bounds of a ShellSurface were relative to the root window, pop-up windows (e.g. context menus in weston-terminal) whose parents are on a secondary display would appear on the primary display. BUG=631136 TEST=Drag weston-terminal to secondary display and right-click. TEST=ARC apps can still be dragged and maximized. Committed: https://crrev.com/9ae6cfed8f37fe4438e00126995dc863c03dd294 Cr-Commit-Position: refs/heads/master@{#408535}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M components/exo/display.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M components/exo/shell_surface.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
Dominik Laskowski
4 years, 4 months ago (2016-07-25 23:52:30 UTC) #4
oshima
lgtm
4 years, 4 months ago (2016-07-26 02:31:43 UTC) #7
reveman
lgtm
4 years, 4 months ago (2016-07-27 03:11:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175373003/1
4 years, 4 months ago (2016-07-29 00:09:22 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 00:46:47 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9ae6cfed8f37fe4438e00126995dc863c03dd294 Cr-Commit-Position: refs/heads/master@{#408535}
4 years, 4 months ago (2016-07-29 00:49:30 UTC) #13
Dominik Laskowski
4 years, 4 months ago (2016-08-02 18:17:21 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2202713005/ by domlaskowski@chromium.org.

The reason for reverting is: Breaks overview mode for ARC windows..

Powered by Google App Engine
This is Rietveld 408576698