Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: PRESUBMIT.py

Issue 2175373002: Move Skia recipes from build repo (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Fixes, add simulation test to presubmit Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 1412b2b95f09222efe8a8e27c93618ecc4ac8377..25b8931ae6ca78634bbd57b608ed25c3096c1221 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -169,6 +169,17 @@ def _ToolFlags(input_api, output_api):
return results
+def _RecipeSimulationTest(input_api, output_api):
+ """Run the recipe simulation test."""
+ results = []
+ recipes_py = os.path.join('infra', 'bots', 'recipes.py')
+ try:
+ subprocess.check_output(['python', recipes_py, 'simulation_test'])
+ except subprocess.CalledProcessError as e:
+ results.append(e.output)
+ return results
+
+
def _CommonChecks(input_api, output_api):
"""Presubmit checks common to upload and commit."""
results = []
@@ -191,6 +202,7 @@ def _CommonChecks(input_api, output_api):
results.extend(_CopyrightChecks(input_api, output_api,
source_file_filter=sources))
results.extend(_ToolFlags(input_api, output_api))
+ results.extend(_RecipeSimulationTest(input_api, output_api))
rmistry 2016/07/26 18:00:38 How long does this take to run? should this only r
borenet 2016/07/26 18:08:45 < 5 seconds. I didn't notice a difference.
return results
« no previous file with comments | « .gitignore ('k') | infra/bots/compile_skia.isolate » ('j') | infra/bots/gen_buildbot_specs.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698