Chromium Code Reviews| Index: PRESUBMIT.py |
| diff --git a/PRESUBMIT.py b/PRESUBMIT.py |
| index 1412b2b95f09222efe8a8e27c93618ecc4ac8377..a3af9e4445b46bc28c05c97698b93d8b28929d42 100644 |
| --- a/PRESUBMIT.py |
| +++ b/PRESUBMIT.py |
| @@ -169,6 +169,19 @@ def _ToolFlags(input_api, output_api): |
| return results |
| +def _RecipeSimulationTest(input_api, output_api): |
| + """Run the recipe simulation test.""" |
| + results = [] |
| + recipes_py = os.path.join('infra', 'bots', 'recipes.py') |
| + cmd = ['python', recipes_py, 'simulation_test'] |
| + try: |
| + subprocess.check_output(cmd) |
| + except subprocess.CalledProcessError as e: |
| + results.append(output_api.PresubmitError( |
| + '`%s` failed:\n%s' % (' '.join(cmd), e.output))) |
| + return results |
| + |
| + |
| def _CommonChecks(input_api, output_api): |
| """Presubmit checks common to upload and commit.""" |
| results = [] |
| @@ -202,6 +215,9 @@ def CheckChangeOnUpload(input_api, output_api): |
| """ |
| results = [] |
| results.extend(_CommonChecks(input_api, output_api)) |
| + # Run on upload, not commit, since the presubmit bot apparently doesn't have |
| + # coverage installed. |
|
rmistry
2016/07/26 18:20:03
Which coverage? python-coverage? we should install
borenet
2016/07/26 18:29:31
I think python-coverage. We don't control that bot
rmistry
2016/07/26 18:51:14
They have bots that run coverage in presubmit so t
|
| + results.extend(_RecipeSimulationTest(input_api, output_api)) |
| return results |