[Remoting Android] Define feedback animation size in dp

remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java

Index: remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java
diff --git a/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java b/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java
index 439eeab6d21644f38faa9a2f30daa45bccf665a7..a0b31142d560e0b98d1915b8c8ddc5130e49f77e 100644
--- a/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java
+++ b/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java
@@ -30,21 +30,12 @@ public class GlDesktopView extends AbstractDesktopView implements SurfaceHolder.
 
     @Override
     public void showInputFeedback(InputFeedbackType feedbackToShow, Point pos) {
-        float diameter;
-        // TODO(yuweih): diameter (and radius in DesktopView) should be defined in dp so that it is
-        // DPI independent.
-        switch (feedbackToShow) {
-            case LARGE_ANIMATION:
-                diameter = 320.f;
-                break;
-            case SMALL_ANIMATION:
-                diameter = 80.f;
-                break;
-            default:
-                return;
+        float diameter = getFeedbackRadius(feedbackToShow) * 2;
+        if (diameter <= 0.0f) {
+            return;
         }
         float scaleFactor = mRenderData.transform.mapRadius(1);
-        mDisplay.showCursorInputFeedback(pos.x, pos.y, diameter / scaleFactor);
+        mDisplay.showCursorInputFeedback(pos.x, pos.y, 2 * diameter / scaleFactor);

[Lambros, 2016/07/26 18:54:17]

Not 2.0f ?

Personally, I prefer just 0 and 2 :)

[Yuwei, 2016/07/26 19:05:43]

Oops... I think I just found a bug here for multiplying 2 by twice...

Yeah.. I think the compiler will optimize away unnecessary type conversions...

For being consistent with the diameter <= 0.0f check, I will change it to 2.0...

     }
 
     @Override