remoting/android/java/src/org/chromium/chromoting/DesktopView.java - Issue 2175353003: [Remoting Android] Define feedback animation size in dp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/android/java/src/org/chromium/chromoting/DesktopView.java

Issue 2175353003: [Remoting Android] Define feedback animation size in dp (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reviewer's Feedback Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « remoting/android/java/src/org/chromium/chromoting/AbstractDesktopView.java ('k') | remoting/android/java/src/org/chromium/chromoting/FeedbackAnimator.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/android/java/src/org/chromium/chromoting/DesktopView.java

diff --git a/remoting/android/java/src/org/chromium/chromoting/DesktopView.java b/remoting/android/java/src/org/chromium/chromoting/DesktopView.java

index d99eb127329e0e5f1011c85c9540bef1c1b2c2e2..1139380e232572aa28450827a695b69ec4eba3b5 100644

--- a/remoting/android/java/src/org/chromium/chromoting/DesktopView.java

+++ b/remoting/android/java/src/org/chromium/chromoting/DesktopView.java

@@ -225,10 +225,12 @@ public class DesktopView extends AbstractDesktopView implements SurfaceHolder.Ca

@Override

public void showInputFeedback(InputFeedbackType feedbackToShow, Point pos) {

- if (feedbackToShow != InputFeedbackType.NONE) {

- FeedbackAnimator.startAnimation(this, pos, feedbackToShow);

- requestRepaint();

+ float radius = getFeedbackRadius(feedbackToShow);

+ if (radius <= 0.0f) {

+ return;

}

+ FeedbackAnimator.startAnimation(this, pos, radius);

+ requestRepaint();

}

@Override