[Remoting Android] Define feedback animation size in dp

remoting/android/java/src/org/chromium/chromoting/AbstractDesktopView.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chromoting;
 
 import android.content.Context;
 import android.graphics.Point;
 import android.text.InputType;
 import android.view.MotionEvent;
@@ skipping 20 matching lines @@
      */
     protected final Event.Raisable<SizeChangedEventParameter> mOnClientSizeChanged =
             new Event.Raisable<>();
 
     /**
      * Subclass should trigger this event when the host (desktop frame) size is changed.
      */
     protected final Event.Raisable<SizeChangedEventParameter> mOnHostSizeChanged =
             new Event.Raisable<>();
 
+    protected final int mSmallFeedbackPixelRadius;
+    protected final int mLargeFeedbackPixelRadius;
+
     /** The parent Desktop activity. */
     private final Desktop mDesktop;
 
     private final Event.Raisable<TouchEventParameter> mOnTouch = new Event.Raisable<>();
 
     public AbstractDesktopView(Desktop desktop, Client client) {
         super(desktop);
         Preconditions.notNull(desktop);
         Preconditions.notNull(client);
         mDesktop = desktop;
         mRenderData = new RenderData();
         mInputHandler = new TouchInputHandler(this, desktop, mRenderData);
         mInputHandler.init(desktop, new InputEventSender(client));
 
         // Give this view keyboard focus, allowing us to customize the soft keyboard's settings.
         setFocusableInTouchMode(true);
+
+        mSmallFeedbackPixelRadius = getResources()
+                .getDimensionPixelSize(R.dimen.feedback_animation_radius_small);
+
+        mLargeFeedbackPixelRadius = getResources()
+                .getDimensionPixelSize(R.dimen.feedback_animation_radius_large);
     }
 
     // TODO(yuweih): move showActionBar and showKeyboard out of this abstract class.
     /** Shows the action bar. */
     public final void showActionBar() {
         mDesktop.showSystemUi();
     }
 
     /** Shows the software keyboard. */
     public final void showKeyboard() {
@@ skipping 37 matching lines @@
     }
 
     /** Called whenever the user attempts to touch the canvas. */
     @Override
     public final boolean onTouchEvent(MotionEvent event) {
         TouchEventParameter parameter = new TouchEventParameter(event);
         mOnTouch.raise(parameter);
         return parameter.handled;
     }
 
+    /** Returns the radius of the given feedback type. 0.0f will be returned if no feedback should

[Lambros, 2016/07/26 18:54:17]

Format this as multi-line:
/**
 * Returns...
 * blah...
 */

[Yuwei, 2016/07/26 19:05:42]

Done.

+     * be shown. */
+    protected final float getFeedbackRadius(InputFeedbackType feedbackToShow) {
+        if (feedbackToShow == InputFeedbackType.NONE) {

[Lambros, 2016/07/26 18:54:17]

Move this into the switch..case.

[Yuwei, 2016/07/26 19:05:42]

Done.

+            return 0.0f;
+        }
+        switch (feedbackToShow) {
+            case SMALL_ANIMATION:
+                return mSmallFeedbackPixelRadius;
+            case LARGE_ANIMATION:
+                return mLargeFeedbackPixelRadius;
+            default:
+                // Unreachable, but required by Google Java style and findbugs.
+                assert false : "Unreached";
+                return 0.0f;
+        }
+    }
+
     /** Triggers a brief animation to indicate the existence and location of an input event. */
     public abstract void showInputFeedback(InputFeedbackType feedbackToShow, Point pos);
 
     /**
      * Informs the view that its transformation matrix (for rendering the remote desktop bitmap)
      * has been changed by the TouchInputHandler, which requires repainting.
      */
     public abstract void transformationChanged();
 
     /**
      * Informs the view that the cursor has been moved by the TouchInputHandler, which requires
      * repainting.
      */
     public abstract void cursorMoved();
 
     /**
      * Informs the view that the cursor visibility has been changed (for different input mode) by
      * the TouchInputHandler, which requires repainting.
      */
     public abstract void cursorVisibilityChanged();
 
     /**
      * Starts or stops an animation. Whilst the animation is running, the DesktopView will
      * periodically call TouchInputHandler.processAnimation() and repaint itself.
      */
     public abstract void setAnimationEnabled(boolean enabled);
 }