[Remoting Android] Define feedback animation size in dp

remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chromoting;
 
 import android.graphics.Point;
 import android.view.SurfaceHolder;
 
 import org.chromium.chromoting.jni.Client;
@@ skipping 11 matching lines @@
 
     public GlDesktopView(GlDisplay display, Desktop desktop, Client client) {
         super(desktop, client);
         Preconditions.notNull(display);
         mDisplay = display;
 
         getHolder().addCallback(this);
     }
 
     @Override
-    public void showInputFeedback(InputFeedbackType feedbackToShow, Point pos) {
-        float diameter;
-        // TODO(yuweih): diameter (and radius in DesktopView) should be defined in dp so that it is
-        // DPI independent.
-        switch (feedbackToShow) {
-            case LARGE_ANIMATION:
-                diameter = 320.f;
-                break;
-            case SMALL_ANIMATION:
-                diameter = 80.f;
-                break;
-            default:
-                return;
-        }
+    public void showInputFeedback(float feedbackRadius, Point pos) {
+        // Note that the OpenGL renderer takes diameter as argument so the radius we got needs
+        // to be multiplied by 2.

[joedow, 2016/07/26 03:03:24]

You could remove the comment and just add a var:
float feedbackDiameter = 2 * feedbackRadius;

The var should be optimized away and the code is self-documenting.

[Yuwei, 2016/07/26 18:47:26]

Done.

+
         float scaleFactor = mRenderData.transform.mapRadius(1);
-        mDisplay.showCursorInputFeedback(pos.x, pos.y, diameter / scaleFactor);
+        mDisplay.showCursorInputFeedback(pos.x, pos.y, 2 * feedbackRadius / scaleFactor);
     }
 
     @Override
     public void transformationChanged() {
         if (mRenderData.imageHeight == 0 || mRenderData.imageWidth == 0
                 || mRenderData.screenHeight == 0 || mRenderData.screenWidth == 0) {
             return;
         }
         float[] matrix = new float[9];
         mRenderData.transform.getValues(matrix);
@@ skipping 60 matching lines @@
     @Override
     public void surfaceDestroyed(SurfaceHolder holder) {
         // GlDisplay's life time spans to the whole session while GlDesktopView may be created and
         // destroyed for multiple times (say when the phone is rotated). It is important to remove
         // the listeners when the surface is about to be destroyed.
         mDisplay.onHostSizeChanged().remove(mOnHostSizeChangedListenerKey);
         mDisplay.onCanvasRendered().remove(mOnCanvasRenderedListenerKey);
         mDisplay.surfaceDestroyed();
     }
 }