remoting/android/java/res/values/dimens.xml - Issue 2175353003: [Remoting Android] Define feedback animation size in dp

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/android/java/res/values/dimens.xml

Issue 2175353003: [Remoting Android] Define feedback animation size in dp (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | remoting/android/java/src/org/chromium/chromoting/FeedbackAnimator.java » ('j') | remoting/android/java/src/org/chromium/chromoting/FeedbackAnimator.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <resources>	6 <resources>

7 <dimen name="toolbar_content_inset_start">72dp</dimen>	7 <dimen name="toolbar_content_inset_start">72dp</dimen>

	8 <dimen name="feedback_animation_radius_small">15dp</dimen>

	9 <dimen name="feedback_animation_radius_large">45dp</dimen>
	joedow 2016/07/25 20:24:18 How did you choose 15/45? It might be good to add How did you choose 15/45? It might be good to add a comment or mention what these are based on in the CL description. Yuwei 2016/07/25 20:57:13 This number will approximately match the current f Show quoted text On 2016/07/25 20:24:18, joedow wrote: > How did you choose 15/45? It might be good to add a comment or mention what > these are based on in the CL description. This number will approximately match the current feedback size on my Nexus 6P (13/48). Just feel like the small radius can be slightly larger and the large radius can be slightly smaller so I just round them to the nearest 5...
8 </resources>	10 </resources>

OLD	NEW