Issue 2175353002: [arc-intents] Adjust link-click detection code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2175353002: [arc-intents] Adjust link-click detection code.

Created:
4 years, 5 months ago by Ben Kwa

Modified:
4 years, 5 months ago

Reviewers:
Luis Héctor Chávez

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

More Reviews

Description

[arc-intents] Adjust link-click detection code. Use the page transition, which seems more reliable, rather than the HasUserGesture method, to detect whether a given navigation event was spawned by the user clicking on a link. BUG=630072 Review-Url: https://codereview.chromium.org/2165193002 Cr-Commit-Position: refs/heads/master@{#407256} (cherry picked from commit ef206ad2f2bd182205b4adb5580c00e7967c4fd8)

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -1 line)			Patch
	M	chrome/browser/chromeos/arc/arc_navigation_throttle.cc	View		2 chunks	+16 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages