Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2175353002: [arc-intents] Adjust link-click detection code.

Created:
4 years, 5 months ago by Ben Kwa
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[arc-intents] Adjust link-click detection code. Use the page transition, which seems more reliable, rather than the HasUserGesture method, to detect whether a given navigation event was spawned by the user clicking on a link. BUG=630072 Review-Url: https://codereview.chromium.org/2165193002 Cr-Commit-Position: refs/heads/master@{#407256} (cherry picked from commit ef206ad2f2bd182205b4adb5580c00e7967c4fd8)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M chrome/browser/chromeos/arc/arc_navigation_throttle.cc View 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
Ben Kwa
4 years, 5 months ago (2016-07-25 16:08:37 UTC) #2
Luis Héctor Chávez
4 years, 5 months ago (2016-07-25 16:14:42 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698