Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: recipe_modules/bot_update/api.py

Issue 2175343002: bot_update: improve UX when gclient is not configured. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: recipe_modules/bot_update/api.py
diff --git a/recipe_modules/bot_update/api.py b/recipe_modules/bot_update/api.py
index 42cf3ec094b18b7041daaef21d87a2750ab19caf..7650a342775115dfc247ca1103a90b5cc13cfbd6 100644
--- a/recipe_modules/bot_update/api.py
+++ b/recipe_modules/bot_update/api.py
@@ -78,6 +78,8 @@ class BotUpdateApi(recipe_api.RecipeApi):
# We can re-use the gclient spec from the gclient module, since all the
# data bot_update needs is already configured into the gclient spec.
cfg = gclient_config or self.m.gclient.c
+ assert cfg is not None, (
+ 'gclient_config or configured in advance gclient module is required')
Bons 2016/07/25 15:21:26 this sentence is hard to follow. since i don't kno
tandrii(chromium) 2016/07/25 15:32:04 How about now?
# Used by bot_update to determine if we want to run or not.
master = self._mastername
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698