Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 217533006: Introduce apps API target in //apps and move app.runtime API into it (Closed)

Created:
6 years, 8 months ago by James Cook
Modified:
6 years, 8 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, tzik, tfarina, nhiroki, chromium-apps-reviews_chromium.org, kinuko+watch
Visibility:
Public.

Description

Introduce apps API target in //apps and move app.runtime API into it This breaks a dependency from //apps onto //chrome, getting us closer to an app_shell build that does not include chrome. * Introduce apps/browser/api and apps/common/api to mirror extensions. * Introduce an apps_api build target. * Hook up schema and function registration in chrome and app_shell. * Move app_runtime_api.h/cc into //apps and switch to apps namespace. * Eliminate AppEventRouter dependencies on Chrome: ** Use ExtensionsBrowserClient to determine if we're in kiosk mode. ** Introduce apps::file_handler_util for GrantedFileEntry (anticipating more code from app_file_handler_util to move there in the future). BUG=357818 TEST=browser_tests *PlatformApp* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260480

Patch Set 1 #

Patch Set 2 : fix android (app-runtime-move) #

Total comments: 1

Patch Set 3 : remove dummy.idl (app-runtime-move) #

Patch Set 4 : fix win (app-runtime-move) #

Patch Set 5 : fix dependencies (app-runtime-move) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -328 lines) Patch
M apps/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M apps/app_restore_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M apps/apps.gypi View 2 chunks +5 lines, -0 lines 0 comments Download
A + apps/browser/api/app_runtime/app_runtime_api.h View 4 chunks +18 lines, -15 lines 0 comments Download
A + apps/browser/api/app_runtime/app_runtime_api.cc View 5 chunks +19 lines, -20 lines 0 comments Download
A apps/browser/file_handler_util.h View 1 chunk +26 lines, -0 lines 0 comments Download
A apps/browser/file_handler_util.cc View 1 chunk +15 lines, -0 lines 0 comments Download
A + apps/common/api/api.gyp View 1 2 3 4 2 chunks +6 lines, -12 lines 0 comments Download
A + apps/common/api/app_runtime.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
D apps/common/api/dummy.idl View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M apps/launcher.cc View 7 chunks +9 lines, -8 lines 0 comments Download
M apps/shell/browser/shell_extension_system.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M apps/shell/browser/shell_extensions_browser_client.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M apps/shell/common/shell_extensions_client.cc View 1 2 3 4 3 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/apps/app_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/apps/app_launch_for_metro_restart_win.cc View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/DEPS View 1 chunk +8 lines, -0 lines 0 comments Download
D chrome/browser/extensions/api/app_runtime/app_runtime_api.h View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/extensions/api/app_runtime/app_runtime_api.cc View 1 chunk +0 lines, -110 lines 0 comments Download
M chrome/browser/extensions/api/file_handlers/app_file_handler_util.h View 2 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc View 1 2 3 4 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/DEPS View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/common/extensions/api/app_runtime.idl View 1 chunk +0 lines, -53 lines 0 comments Download
M chrome/common/extensions/chrome_extensions_client.cc View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
James Cook
kalman, PTAL
6 years, 8 months ago (2014-03-28 22:46:17 UTC) #1
not at google - send to devlin
I don't think I'm the best person to review this, Ken perhaps?
6 years, 8 months ago (2014-03-28 23:26:11 UTC) #2
Ken Rockot(use gerrit already)
LGTM - can you please also delete the dummy.idl file from //apps/common/api in this CL? ...
6 years, 8 months ago (2014-03-28 23:41:25 UTC) #3
James Cook
kalman, can I get an OWNERS stamp?
6 years, 8 months ago (2014-03-28 23:49:16 UTC) #4
not at google - send to devlin
lgtm
6 years, 8 months ago (2014-03-28 23:50:23 UTC) #5
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 8 months ago (2014-03-28 23:56:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/217533006/2
6 years, 8 months ago (2014-03-29 00:02:03 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 00:38:17 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=290766
6 years, 8 months ago (2014-03-29 00:38:17 UTC) #9
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 8 months ago (2014-03-29 04:40:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/217533006/50001
6 years, 8 months ago (2014-03-29 04:41:37 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 05:44:11 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=290837
6 years, 8 months ago (2014-03-29 05:44:11 UTC) #13
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-03-30 17:25:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/217533006/50001
6 years, 8 months ago (2014-03-30 17:25:43 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-30 20:54:48 UTC) #16
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, base_unittests, base_unittests_swarm, browser_tests, ...
6 years, 8 months ago (2014-03-30 20:54:48 UTC) #17
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 8 months ago (2014-03-30 23:51:13 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/217533006/70001
6 years, 8 months ago (2014-03-30 23:51:14 UTC) #19
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 01:54:40 UTC) #20
Message was sent while issue was closed.
Change committed as 260480

Powered by Google App Engine
This is Rietveld 408576698