Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 217533005: Invoke setup.exe to reenable updates when the update bubble is clicked. (Closed)

Created:
6 years, 9 months ago by grt (UTC plus 2)
Modified:
6 years, 8 months ago
Reviewers:
MAD, robertshield, sky
CC:
chromium-reviews, tfarina, grt+watch_chromium.org
Visibility:
Public.

Description

Invoke setup.exe to reenable updates when the update bubble is clicked. When Chrome detects it is out of date and the user clicks to reenable updates, this will shell out to setup.exe, elevate if necessary and perform the needed actions to reenable updates. Copied from https://codereview.chromium.org/216153006/ by robertshield@chromium.org. TBR=sky BUG=164681, 171271 TEST=Run chrome.exe --simulate-outdated-no-au and click on reenable updates while Omaha group policy to disable updates is applied. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260388

Patch Set 1 #

Patch Set 2 : fix compile issues and command line generation #

Patch Set 3 : show elevation icon for user-level installs #

Patch Set 4 : i can haz linux compile? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -9 lines) Patch
M chrome/browser/ui/views/outdated_upgrade_bubble_view.cc View 1 2 3 5 chunks +10 lines, -7 lines 0 comments Download
M chrome/installer/setup/setup_main.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/installer/util/google_update_util.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/installer/util/google_update_util.cc View 1 3 chunks +49 lines, -0 lines 0 comments Download
M chrome/installer/util/util_constants.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/installer/util/util_constants.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 20 (0 generated)
grt (UTC plus 2)
Hi guys, Here's a take on Robert's CL that changes a few things: 1. The ...
6 years, 9 months ago (2014-03-29 02:01:55 UTC) #1
robertshield
LGTM
6 years, 8 months ago (2014-03-29 03:26:29 UTC) #2
grt (UTC plus 2)
sky@chromium.org: Please review changes in outdated_upgrade_bubble_view.cc. thanks.
6 years, 8 months ago (2014-03-29 03:29:08 UTC) #3
robertshield
TBRing sky@ for OWNERS on the outdated_upgrade_bubble_view.cc change, it is minor and hopefully uncontroversial.
6 years, 8 months ago (2014-03-29 03:41:02 UTC) #4
robertshield
The CQ bit was checked by robertshield@chromium.org
6 years, 8 months ago (2014-03-29 03:41:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/217533005/60001
6 years, 8 months ago (2014-03-29 03:41:40 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 04:37:08 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-29 04:37:09 UTC) #8
grt (UTC plus 2)
The CQ bit was checked by grt@chromium.org
6 years, 8 months ago (2014-03-29 11:32:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/217533005/60001
6 years, 8 months ago (2014-03-29 11:33:00 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 12:26:44 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=290864
6 years, 8 months ago (2014-03-29 12:26:45 UTC) #12
grt (UTC plus 2)
The CQ bit was checked by grt@chromium.org
6 years, 8 months ago (2014-03-29 12:46:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/217533005/60001
6 years, 8 months ago (2014-03-29 12:46:32 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 14:37:46 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-29 14:37:47 UTC) #16
grt (UTC plus 2)
landing with NOTRY=true since linux_chromium_chromeos_rel failures are unrelated to this change, and seem to be ...
6 years, 8 months ago (2014-03-29 15:06:37 UTC) #17
grt (UTC plus 2)
The CQ bit was checked by grt@chromium.org
6 years, 8 months ago (2014-03-29 15:06:42 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/217533005/60001
6 years, 8 months ago (2014-03-29 15:06:58 UTC) #19
commit-bot: I haz the power
6 years, 8 months ago (2014-03-29 17:55:33 UTC) #20
Message was sent while issue was closed.
Change committed as 260388

Powered by Google App Engine
This is Rietveld 408576698