Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2175313003: [Android] Make perf test runner in platform mode check that return value is not None. (Closed)

Created:
4 years, 4 months ago by rnephew (Reviews Here)
Modified:
4 years, 4 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Make perf test runner in platform mode check that return value is not None. BUG=630627, 615157 Committed: https://crrev.com/6c4a773fb2b4dc7b71051460a534ae8c0c3ac006 Cr-Commit-Position: refs/heads/master@{#407598}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/pylib/local/device/local_device_perf_test_run.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
rnephew (Reviews Here)
4 years, 4 months ago (2016-07-25 18:36:28 UTC) #2
jbudorick
lgtm
4 years, 4 months ago (2016-07-25 18:37:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175313003/1
4 years, 4 months ago (2016-07-25 18:44:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/261615)
4 years, 4 months ago (2016-07-25 21:00:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175313003/1
4 years, 4 months ago (2016-07-25 21:04:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-25 21:49:04 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-25 21:52:59 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c4a773fb2b4dc7b71051460a534ae8c0c3ac006
Cr-Commit-Position: refs/heads/master@{#407598}

Powered by Google App Engine
This is Rietveld 408576698