src/lookup.h - Issue 2175273002: [ic] Don't call LookupIterator::GetStoreTarget() when receiver is not a JSReceiver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/lookup.h

Issue 2175273002: [ic] Don't call LookupIterator::GetStoreTarget() when receiver is not a JSReceiver. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/lookup.h

diff --git a/src/lookup.h b/src/lookup.h

index a1e39599cc4b2b0769cc2bbe041c3f28cfc291de..ffc7904b2add60da6463943b49ca5175487b448d 100644

--- a/src/lookup.h

+++ b/src/lookup.h

@@ -176,6 +176,7 @@ class LookupIterator final BASE_EMBEDDED {

Handle<Object> GetReceiver() const { return receiver_; }

Handle<JSObject> GetStoreTarget() const {

+ DCHECK(receiver_->IsJSObject());

jochen (gone - plz use gerrit) 2016/07/25 11:53:36 why not ISJSReceiver?

Igor Sheludko 2016/07/25 11:57:39 Because we cast it to JSObject below.

if (receiver_->IsJSGlobalProxy()) {

Map* map = JSGlobalProxy::cast(*receiver_)->map();

if (map->has_hidden_prototype()) {

« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »