[ic] Don't call LookupIterator::GetStoreTarget() when receiver is not a JSReceiver.

[ic] Don't call LookupIterator::GetStoreTarget() when receiver is not a JSReceiver.

BUG=chromium:619166, chromium:625155
Committed: https://crrev.com/5c8cb1689a543955cd1a47d3c323f8710b8b0f15
Cr-Commit-Position: refs/heads/master@{#38018}

[Igor Sheludko, 2016-07-25 11:28:11]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 11:28:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-07-25 11:49:44]

ishell@chromium.org changed reviewers:
+ jochen@chromium.org

[Igor Sheludko, 2016-07-25 11:49:45]

PTAL

[jochen (gone - plz use gerrit), 2016-07-25 11:53:36]

lgtm

https://codereview.chromium.org/2175273002/diff/1/src/lookup.h
File src/lookup.h (right):

https://codereview.chromium.org/2175273002/diff/1/src/lookup.h#newcode179
src/lookup.h:179: DCHECK(receiver_->IsJSObject());
why not ISJSReceiver?

[jochen (gone - plz use gerrit), 2016-07-25 11:57:10]

alternatively, we could convert to a JSReceiver which we'll do for the
interceptor anyways

[Igor Sheludko, 2016-07-25 11:57:39]

https://codereview.chromium.org/2175273002/diff/1/src/lookup.h
File src/lookup.h (right):

https://codereview.chromium.org/2175273002/diff/1/src/lookup.h#newcode179
src/lookup.h:179: DCHECK(receiver_->IsJSObject());
On 2016/07/25 11:53:36, jochen wrote:
> why not ISJSReceiver?

Because we cast it to JSObject below.

[commit-bot: I haz the power, 2016-07-25 11:58:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 11:58:07]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-07-25 11:58:44]

On 2016/07/25 11:57:10, jochen wrote:
> alternatively, we could convert to a JSReceiver which we'll do for the
> interceptor anyways

It's going to be a big change and I would prefer to leave it to Toon.

[Igor Sheludko, 2016-07-25 12:06:15]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-07-25 12:06:15]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2175273002/#ps20001
(title: "Addressing comments")

[commit-bot: I haz the power, 2016-07-25 12:06:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 12:30:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-25 12:33:04]

Description was changed from

==========
[ic] Don't call LookupIterator::GetStoreTarget() when receiver is not a
JSReceiver.

BUG=chromium:619166,chromium:625155
==========

to

==========
[ic] Don't call LookupIterator::GetStoreTarget() when receiver is not a
JSReceiver.

BUG=chromium:619166,chromium:625155

Committed: https://crrev.com/5c8cb1689a543955cd1a47d3c323f8710b8b0f15
Cr-Commit-Position: refs/heads/master@{#38018}
==========

[commit-bot: I haz the power, 2016-07-25 12:33:05]

Patchset 2 (id:??) landed as
https://crrev.com/5c8cb1689a543955cd1a47d3c323f8710b8b0f15
Cr-Commit-Position: refs/heads/master@{#38018}