Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2175)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnectionFactory.java

Issue 2175263002: Cache proxy view return value to avoid deadlock (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: set to null Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnectionFactory.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnectionFactory.java b/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnectionFactory.java
index 496c7750e6ac4855f59a56fec30c9711a4a40ec4..702690499f7d34ff3032324a1a240feda6623514 100644
--- a/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnectionFactory.java
+++ b/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnectionFactory.java
@@ -217,17 +217,26 @@ public class ThreadedInputConnectionFactory implements ChromiumBaseInputConnecti
public void onWindowFocusChanged(boolean gainFocus) {
if (DEBUG_LOGS) Log.d(TAG, "onWindowFocusChanged: " + gainFocus);
if (!gainFocus && mCheckInvalidator != null) mCheckInvalidator.invalidate();
+ if (mProxyView != null) mProxyView.onOriginalViewWindowFocusChanged(gainFocus);
}
@Override
public void onViewFocusChanged(boolean gainFocus) {
if (DEBUG_LOGS) Log.d(TAG, "onViewFocusChanged: " + gainFocus);
if (!gainFocus && mCheckInvalidator != null) mCheckInvalidator.invalidate();
+ if (mProxyView != null) mProxyView.onOriginalViewFocusChanged(gainFocus);
+ }
+
+ @Override
+ public void onViewAttachedToWindow() {
+ if (DEBUG_LOGS) Log.d(TAG, "onViewAttachedToWindow");
+ if (mProxyView != null) mProxyView.onOriginalViewAttachedToWindow();
}
@Override
public void onViewDetachedFromWindow() {
if (DEBUG_LOGS) Log.d(TAG, "onViewDetachedFromWindow");
if (mCheckInvalidator != null) mCheckInvalidator.invalidate();
+ if (mProxyView != null) mProxyView.onOriginalViewDetachedFromWindow();
}
}

Powered by Google App Engine
This is Rietveld 408576698