Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2175243004: services/{ui,shell}: Change auto to not deduce raw pointers. (Closed)

Created:
4 years, 4 months ago by vmpstr
Modified:
4 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

services/{ui,shell}: Change auto to not deduce raw pointers. This patch updates the code to prevent auto deducing to a raw pointer. R=sky@chromium.org BUG=554600 Committed: https://crrev.com/6b86f80e5578519fcf5b3a19767bd53e86112f15 Cr-Commit-Position: refs/heads/master@{#407872}

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M services/shell/service_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M services/ui/display/platform_screen_impl_ozone.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/gles2/command_buffer_driver_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/ws/frame_generator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/ws/modal_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/window_tree.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
vmpstr
Please take a look.
4 years, 4 months ago (2016-07-26 00:43:05 UTC) #1
sky
LGTM
4 years, 4 months ago (2016-07-26 13:35:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175243004/20001
4 years, 4 months ago (2016-07-26 18:06:43 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-26 19:04:55 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 19:07:49 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6b86f80e5578519fcf5b3a19767bd53e86112f15
Cr-Commit-Position: refs/heads/master@{#407872}

Powered by Google App Engine
This is Rietveld 408576698