Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Unified Diff: test/cctest/interpreter/generate-bytecode-expectations.cc

Issue 2175233003: Replace SmartPointer<T> with unique_ptr<T> (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@smart-array
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/interpreter/generate-bytecode-expectations.cc
diff --git a/test/cctest/interpreter/generate-bytecode-expectations.cc b/test/cctest/interpreter/generate-bytecode-expectations.cc
index f8237593e4ce84d79a7fed7e8c795f90306002a4..7817d94f0383cb81453aae70cb4216af8c032435 100644
--- a/test/cctest/interpreter/generate-bytecode-expectations.cc
+++ b/test/cctest/interpreter/generate-bytecode-expectations.cc
@@ -4,6 +4,7 @@
#include <cstring>
#include <fstream>
+#include <memory>
#include <vector>
#include "test/cctest/interpreter/bytecode-expectations-printer.h"
@@ -12,7 +13,6 @@
#include "include/v8.h"
#include "src/base/logging.h"
-#include "src/base/smart-pointers.h"
#include "src/compiler.h"
#include "src/interpreter/interpreter.h"
@@ -102,8 +102,8 @@ class V8InitializationScope final {
v8::Isolate* isolate() const { return isolate_; }
private:
- v8::base::SmartPointer<v8::Platform> platform_;
- v8::base::SmartPointer<v8::ArrayBuffer::Allocator> allocator_;
+ std::unique_ptr<v8::Platform> platform_;
+ std::unique_ptr<v8::ArrayBuffer::Allocator> allocator_;
v8::Isolate* isolate_;
DISALLOW_COPY_AND_ASSIGN(V8InitializationScope);
@@ -354,7 +354,7 @@ V8InitializationScope::V8InitializationScope(const char* exec_path)
v8::V8::Initialize();
v8::Isolate::CreateParams create_params;
- allocator_.Reset(v8::ArrayBuffer::Allocator::NewDefaultAllocator());
+ allocator_.reset(v8::ArrayBuffer::Allocator::NewDefaultAllocator());
create_params.array_buffer_allocator = allocator_.get();
isolate_ = v8::Isolate::New(create_params);

Powered by Google App Engine
This is Rietveld 408576698