Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: src/wasm/wasm-module.h

Issue 2175233003: Replace SmartPointer<T> with unique_ptr<T> (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@smart-array
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/wasm/wasm-module.h
diff --git a/src/wasm/wasm-module.h b/src/wasm/wasm-module.h
index 6bab4e6e725d6a05f2927a3f98a07921894480ea..8ff64fe1da70eb8276fc9ede6c6d076f9f2f9939 100644
--- a/src/wasm/wasm-module.h
+++ b/src/wasm/wasm-module.h
@@ -5,6 +5,8 @@
#ifndef V8_WASM_MODULE_H_
#define V8_WASM_MODULE_H_
+#include <memory>
+
#include "src/api.h"
#include "src/handles.h"
#include "src/wasm/wasm-opcodes.h"
@@ -188,7 +190,7 @@ struct WasmModule {
// invalid-semaphore error in the compilation tasks.
// TODO(wasm): Move this semaphore back to CompileInParallel when the try bots
// switch to libc-2.21 or higher.
- base::SmartPointer<base::Semaphore> pending_tasks;
+ std::unique_ptr<base::Semaphore> pending_tasks;
WasmModule() : WasmModule(nullptr) {}
explicit WasmModule(byte* module_start);
@@ -243,6 +245,9 @@ struct WasmModule {
DCHECK_LE(function_table.size(), UINT32_MAX);
return static_cast<uint32_t>(function_table.size());
}
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(WasmModule);
};
// An instantiated WASM module, including memory, function table, etc.
« src/profiler/heap-profiler.h ('K') | « src/wasm/encoder.h ('k') | src/wasm/wasm-result.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698