Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1132)

Unified Diff: src/profiler/sampling-heap-profiler.h

Issue 2175233003: Replace SmartPointer<T> with unique_ptr<T> (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@smart-array
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/profiler/sampling-heap-profiler.h
diff --git a/src/profiler/sampling-heap-profiler.h b/src/profiler/sampling-heap-profiler.h
index 4b7c366b8078a7df724603f7969d5e5912c410e3..07840244ce5e916bdafda0071b38bbe781e5a122 100644
--- a/src/profiler/sampling-heap-profiler.h
+++ b/src/profiler/sampling-heap-profiler.h
@@ -7,6 +7,7 @@
#include <deque>
#include <map>
+#include <memory>
#include <set>
#include "include/v8-profiler.h"
#include "src/heap/heap.h"
@@ -141,8 +142,8 @@ class SamplingHeapProfiler {
Isolate* const isolate_;
Heap* const heap_;
- base::SmartPointer<SamplingAllocationObserver> new_space_observer_;
- base::SmartPointer<SamplingAllocationObserver> other_spaces_observer_;
+ std::unique_ptr<SamplingAllocationObserver> new_space_observer_;
+ std::unique_ptr<SamplingAllocationObserver> other_spaces_observer_;
StringsStorage* const names_;
AllocationNode profile_root_;
std::set<Sample*> samples_;
@@ -151,6 +152,8 @@ class SamplingHeapProfiler {
v8::HeapProfiler::SamplingFlags flags_;
friend class SamplingAllocationObserver;
+
+ DISALLOW_COPY_AND_ASSIGN(SamplingHeapProfiler);
};
class SamplingAllocationObserver : public AllocationObserver {

Powered by Google App Engine
This is Rietveld 408576698