Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: src/background-parsing-task.h

Issue 2175233003: Replace SmartPointer<T> with unique_ptr<T> (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@smart-array
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/background-parsing-task.h
diff --git a/src/background-parsing-task.h b/src/background-parsing-task.h
index 0f290fb7f052fef4577b5a0f365795bcea0ca76e..08049e7513476474d3f1dc48c7296e53dffd4d51 100644
--- a/src/background-parsing-task.h
+++ b/src/background-parsing-task.h
@@ -5,9 +5,10 @@
#ifndef V8_BACKGROUND_PARSING_TASK_H_
#define V8_BACKGROUND_PARSING_TASK_H_
+#include <memory>
+
#include "src/base/platform/platform.h"
#include "src/base/platform/semaphore.h"
-#include "src/base/smart-pointers.h"
#include "src/compiler.h"
#include "src/parsing/parser.h"
@@ -23,17 +24,17 @@ struct StreamedSource {
: source_stream(source_stream), encoding(encoding) {}
// Internal implementation of v8::ScriptCompiler::StreamedSource.
- base::SmartPointer<ScriptCompiler::ExternalSourceStream> source_stream;
+ std::unique_ptr<ScriptCompiler::ExternalSourceStream> source_stream;
ScriptCompiler::StreamedSource::Encoding encoding;
- base::SmartPointer<ScriptCompiler::CachedData> cached_data;
+ std::unique_ptr<ScriptCompiler::CachedData> cached_data;
// Data needed for parsing, and data needed to to be passed between thread
// between parsing and compilation. These need to be initialized before the
// compilation starts.
UnicodeCache unicode_cache;
- base::SmartPointer<Zone> zone;
- base::SmartPointer<ParseInfo> info;
- base::SmartPointer<Parser> parser;
+ std::unique_ptr<Zone> zone;
+ std::unique_ptr<ParseInfo> info;
+ std::unique_ptr<Parser> parser;
private:
// Prevent copying. Not implemented.

Powered by Google App Engine
This is Rietveld 408576698