Replace SmartPointer<T> with unique_ptr<T>

src/compiler/pipeline-statistics.h

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_PIPELINE_STATISTICS_H_
 #define V8_COMPILER_PIPELINE_STATISTICS_H_
 
+#include <memory>
 #include <string>
 
 #include "src/base/platform/elapsed-timer.h"
-#include "src/base/smart-pointers.h"
 #include "src/compilation-statistics.h"
 #include "src/compiler/zone-pool.h"
 
 namespace v8 {
 namespace internal {
 namespace compiler {
 
 class PhaseScope;
 
 class PipelineStatistics : public Malloced {
@@ skipping 10 matching lines @@
   }
 
   class CommonStats {
    public:
     CommonStats() : outer_zone_initial_size_(0) {}
 
     void Begin(PipelineStatistics* pipeline_stats);
     void End(PipelineStatistics* pipeline_stats,
              CompilationStatistics::BasicStats* diff);
 
-    base::SmartPointer<ZonePool::StatsScope> scope_;
+    std::unique_ptr<ZonePool::StatsScope> scope_;
     base::ElapsedTimer timer_;
     size_t outer_zone_initial_size_;
     size_t allocated_bytes_at_start_;
+
+   private:
+    DISALLOW_COPY_AND_ASSIGN(CommonStats);
   };
 
-  bool InPhaseKind() { return !phase_kind_stats_.scope_.is_empty(); }
+  bool InPhaseKind() { return !!phase_kind_stats_.scope_; }

[Igor Sheludko, 2016/07/25 09:58:10]

!! is not necessary.

[jochen (gone - plz use gerrit), 2016/07/25 10:34:38]

the operator bool if unique_ptr is explicit, so just returning will not work:

error: no viable conversion from returned value of type
'std::unique_ptr<ZonePool::StatsScope>' to function return type 'bool'

[Igor Sheludko, 2016/07/25 10:46:52]

Ok, I see.

 
   friend class PhaseScope;
-  bool InPhase() { return !phase_stats_.scope_.is_empty(); }
+  bool InPhase() { return !!phase_stats_.scope_; }

[Igor Sheludko, 2016/07/25 09:58:10]

same here

   void BeginPhase(const char* name);
   void EndPhase();
 
   Isolate* isolate_;
   Zone* outer_zone_;
   ZonePool* zone_pool_;
   CompilationStatistics* compilation_stats_;
   std::string function_name_;
 
   // Stats for the entire compilation.
@@ skipping 26 matching lines @@
   PipelineStatistics* const pipeline_stats_;
 
   DISALLOW_COPY_AND_ASSIGN(PhaseScope);
 };
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8
 
 #endif