Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: src/background-parsing-task.cc

Issue 2175233003: Replace SmartPointer<T> with unique_ptr<T> (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@smart-array
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/background-parsing-task.h" 5 #include "src/background-parsing-task.h"
6 #include "src/debug/debug.h" 6 #include "src/debug/debug.h"
7 7
8 namespace v8 { 8 namespace v8 {
9 namespace internal { 9 namespace internal {
10 10
11 BackgroundParsingTask::BackgroundParsingTask( 11 BackgroundParsingTask::BackgroundParsingTask(
12 StreamedSource* source, ScriptCompiler::CompileOptions options, 12 StreamedSource* source, ScriptCompiler::CompileOptions options,
13 int stack_size, Isolate* isolate) 13 int stack_size, Isolate* isolate)
14 : source_(source), stack_size_(stack_size) { 14 : source_(source), stack_size_(stack_size) {
15 // We don't set the context to the CompilationInfo yet, because the background 15 // We don't set the context to the CompilationInfo yet, because the background
16 // thread cannot do anything with it anyway. We set it just before compilation 16 // thread cannot do anything with it anyway. We set it just before compilation
17 // on the foreground thread. 17 // on the foreground thread.
18 DCHECK(options == ScriptCompiler::kProduceParserCache || 18 DCHECK(options == ScriptCompiler::kProduceParserCache ||
19 options == ScriptCompiler::kProduceCodeCache || 19 options == ScriptCompiler::kProduceCodeCache ||
20 options == ScriptCompiler::kNoCompileOptions); 20 options == ScriptCompiler::kNoCompileOptions);
21 21
22 // Prepare the data for the internalization phase and compilation phase, which 22 // Prepare the data for the internalization phase and compilation phase, which
23 // will happen in the main thread after parsing. 23 // will happen in the main thread after parsing.
24 Zone* zone = new Zone(isolate->allocator()); 24 Zone* zone = new Zone(isolate->allocator());
25 ParseInfo* info = new ParseInfo(zone); 25 ParseInfo* info = new ParseInfo(zone);
26 source->zone.Reset(zone); 26 source->zone.reset(zone);
27 source->info.Reset(info); 27 source->info.reset(info);
28 info->set_isolate(isolate); 28 info->set_isolate(isolate);
29 info->set_source_stream(source->source_stream.get()); 29 info->set_source_stream(source->source_stream.get());
30 info->set_source_stream_encoding(source->encoding); 30 info->set_source_stream_encoding(source->encoding);
31 info->set_hash_seed(isolate->heap()->HashSeed()); 31 info->set_hash_seed(isolate->heap()->HashSeed());
32 info->set_global(); 32 info->set_global();
33 info->set_unicode_cache(&source_->unicode_cache); 33 info->set_unicode_cache(&source_->unicode_cache);
34 info->set_compile_options(options); 34 info->set_compile_options(options);
35 // Parse eagerly with ignition since we will compile eagerly. 35 // Parse eagerly with ignition since we will compile eagerly.
36 info->set_allow_lazy_parsing(!(i::FLAG_ignition && i::FLAG_ignition_eager)); 36 info->set_allow_lazy_parsing(!(i::FLAG_ignition && i::FLAG_ignition_eager));
37 } 37 }
(...skipping 10 matching lines...) Expand all
48 options == ScriptCompiler::kProduceCodeCache) { 48 options == ScriptCompiler::kProduceCodeCache) {
49 source_->info->set_cached_data(&script_data); 49 source_->info->set_cached_data(&script_data);
50 } 50 }
51 51
52 uintptr_t stack_limit = 52 uintptr_t stack_limit =
53 reinterpret_cast<uintptr_t>(&stack_limit) - stack_size_ * KB; 53 reinterpret_cast<uintptr_t>(&stack_limit) - stack_size_ * KB;
54 54
55 source_->info->set_stack_limit(stack_limit); 55 source_->info->set_stack_limit(stack_limit);
56 // Parser needs to stay alive for finalizing the parsing on the main 56 // Parser needs to stay alive for finalizing the parsing on the main
57 // thread. Passing &parse_info is OK because Parser doesn't store it. 57 // thread. Passing &parse_info is OK because Parser doesn't store it.
58 source_->parser.Reset(new Parser(source_->info.get())); 58 source_->parser.reset(new Parser(source_->info.get()));
59 source_->parser->ParseOnBackground(source_->info.get()); 59 source_->parser->ParseOnBackground(source_->info.get());
60 60
61 if (script_data != NULL) { 61 if (script_data != NULL) {
62 source_->cached_data.Reset(new ScriptCompiler::CachedData( 62 source_->cached_data.reset(new ScriptCompiler::CachedData(
63 script_data->data(), script_data->length(), 63 script_data->data(), script_data->length(),
64 ScriptCompiler::CachedData::BufferOwned)); 64 ScriptCompiler::CachedData::BufferOwned));
65 script_data->ReleaseDataOwnership(); 65 script_data->ReleaseDataOwnership();
66 delete script_data; 66 delete script_data;
67 } 67 }
68 } 68 }
69 } // namespace internal 69 } // namespace internal
70 } // namespace v8 70 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698