Replace SmartPointer<T> with unique_ptr<T>

Replace SmartPointer<T> with unique_ptr<T>

R=ishell@chromium.org,bmeurer@chromium.org
TBR=rossberg@chromium.org
BUG=

Committed: https://crrev.com/0a6ccaf2684ff5972cb7a307c5270aa977c82483
Cr-Commit-Position: refs/heads/master@{#38009}

[Yang, 2016-07-25 08:58:27]

yangguo@chromium.org changed reviewers:
+ yangguo@chromium.org

[Yang, 2016-07-25 08:58:27]

src/{debug,profiler,snapshot} lgtm.

[jochen (gone - plz use gerrit), 2016-07-25 09:40:20]

Patchset #2 (id:20001) has been deleted

[Igor Sheludko, 2016-07-25 09:58:10]

lgtm with nits:

https://codereview.chromium.org/2175233003/diff/1/src/compiler/pipeline-stati...
File src/compiler/pipeline-statistics.h (right):

https://codereview.chromium.org/2175233003/diff/1/src/compiler/pipeline-stati...
src/compiler/pipeline-statistics.h:51: bool InPhaseKind() { return
!!phase_kind_stats_.scope_; }
!! is not necessary.

https://codereview.chromium.org/2175233003/diff/1/src/compiler/pipeline-stati...
src/compiler/pipeline-statistics.h:54: bool InPhase() { return
!!phase_stats_.scope_; }
same here

https://codereview.chromium.org/2175233003/diff/1/src/profiler/heap-profiler.h
File src/profiler/heap-profiler.h (right):

https://codereview.chromium.org/2175233003/diff/1/src/profiler/heap-profiler....
src/profiler/heap-profiler.h:37: bool is_sampling_allocations() { return
!!sampling_heap_profiler_; }
same here

https://codereview.chromium.org/2175233003/diff/1/src/profiler/heap-profiler....
src/profiler/heap-profiler.h:70: bool is_tracking_allocations() const { return
!!allocation_tracker_; }
same here

[Benedikt Meurer, 2016-07-25 10:23:33]

LGTM (rubber-stamped)

[jochen (gone - plz use gerrit), 2016-07-25 10:34:38]

https://codereview.chromium.org/2175233003/diff/1/src/compiler/pipeline-stati...
File src/compiler/pipeline-statistics.h (right):

https://codereview.chromium.org/2175233003/diff/1/src/compiler/pipeline-stati...
src/compiler/pipeline-statistics.h:51: bool InPhaseKind() { return
!!phase_kind_stats_.scope_; }
On 2016/07/25 at 09:58:10, Igor Sheludko wrote:
> !! is not necessary.

the operator bool if unique_ptr is explicit, so just returning will not work:

error: no viable conversion from returned value of type
'std::unique_ptr<ZonePool::StatsScope>' to function return type 'bool'

[Igor Sheludko, 2016-07-25 10:46:52]

https://codereview.chromium.org/2175233003/diff/1/src/compiler/pipeline-stati...
File src/compiler/pipeline-statistics.h (right):

https://codereview.chromium.org/2175233003/diff/1/src/compiler/pipeline-stati...
src/compiler/pipeline-statistics.h:51: bool InPhaseKind() { return
!!phase_kind_stats_.scope_; }
On 2016/07/25 10:34:38, jochen wrote:
> On 2016/07/25 at 09:58:10, Igor Sheludko wrote:
> > !! is not necessary.
> 
> the operator bool if unique_ptr is explicit, so just returning will not work:
> 
> error: no viable conversion from returned value of type
> 'std::unique_ptr<ZonePool::StatsScope>' to function return type 'bool'

Ok, I see.

[jochen (gone - plz use gerrit), 2016-07-25 10:47:24]

Description was changed from

==========
Replace SmartPointer<T> with unique_ptr<T>

R=ishell@chromium.org,bmeurer@chromium.org,rossberg@chromium.org
BUG=
==========

to

==========
Replace SmartPointer<T> with unique_ptr<T>

R=ishell@chromium.org,bmeurer@chromium.org
TBR=rossberg@chromium.org
BUG=
==========

[jochen (gone - plz use gerrit), 2016-07-25 10:47:27]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2016-07-25 10:47:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 11:12:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-25 11:14:38]

Description was changed from

==========
Replace SmartPointer<T> with unique_ptr<T>

R=ishell@chromium.org,bmeurer@chromium.org
TBR=rossberg@chromium.org
BUG=
==========

to

==========
Replace SmartPointer<T> with unique_ptr<T>

R=ishell@chromium.org,bmeurer@chromium.org
TBR=rossberg@chromium.org
BUG=

Committed: https://crrev.com/0a6ccaf2684ff5972cb7a307c5270aa977c82483
Cr-Commit-Position: refs/heads/master@{#38009}
==========

[commit-bot: I haz the power, 2016-07-25 11:14:39]

Patchset 1 (id:??) landed as
https://crrev.com/0a6ccaf2684ff5972cb7a307c5270aa977c82483
Cr-Commit-Position: refs/heads/master@{#38009}