Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2175233003: Replace SmartPointer<T> with unique_ptr<T> (Closed)

Created:
4 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 5 months ago
CC:
Hannes Payer (out of office), oth, rmcilroy, ulan, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@smart-array
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Replace SmartPointer<T> with unique_ptr<T> R=ishell@chromium.org,bmeurer@chromium.org TBR=rossberg@chromium.org BUG= Committed: https://crrev.com/0a6ccaf2684ff5972cb7a307c5270aa977c82483 Cr-Commit-Position: refs/heads/master@{#38009}

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -237 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/codegen-arm.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/ast/ast.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/background-parsing-task.h View 2 chunks +7 lines, -6 lines 0 comments Download
M src/background-parsing-task.cc View 2 chunks +4 lines, -4 lines 0 comments Download
D src/base/smart-pointers.h View 1 chunk +0 lines, -104 lines 0 comments Download
M src/compiler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/code-assembler.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/graph-visualizer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/pipeline.cc View 5 chunks +10 lines, -8 lines 0 comments Download
M src/compiler/pipeline-statistics.h View 2 chunks +7 lines, -4 lines 4 comments Download
M src/compiler/pipeline-statistics.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/wasm-compiler.h View 2 chunks +6 lines, -2 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M src/debug/debug.cc View 8 chunks +9 lines, -7 lines 0 comments Download
M src/debug/debug-scopes.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M src/fast-accessor-assembler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap/spaces.h View 3 chunks +4 lines, -1 line 0 comments Download
M src/interpreter/interpreter-assembler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/interpreter/interpreter-intrinsics.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/codegen-mips.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/mips64/codegen-mips64.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/objects.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ppc/codegen-ppc.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/profiler/heap-profiler.h View 4 chunks +10 lines, -9 lines 2 comments Download
M src/profiler/heap-profiler.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M src/profiler/sampling-heap-profiler.h View 3 chunks +5 lines, -2 lines 0 comments Download
M src/profiler/strings-storage.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-i18n.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-internal.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/s390/codegen-s390.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/snapshot/code-serializer.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/string-stream.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M src/wasm/decoder.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/wasm/encoder.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/wasm/wasm-module.h View 3 chunks +6 lines, -1 line 0 comments Download
M src/wasm/wasm-result.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode-expectations-printer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/generate-bytecode-expectations.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-heap-profiler.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M test/cctest/test-lockers.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 2 chunks +3 lines, -1 line 0 comments Download
M test/unittests/compiler/instruction-sequence-unittest.h View 3 chunks +5 lines, -1 line 0 comments Download
M test/unittests/compiler/instruction-sequence-unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/unittests/compiler/scheduler-rpo-unittest.cc View 11 chunks +16 lines, -14 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (5 generated)
jochen (gone - plz use gerrit)
4 years, 5 months ago (2016-07-25 08:46:38 UTC) #1
Yang
src/{debug,profiler,snapshot} lgtm.
4 years, 5 months ago (2016-07-25 08:58:27 UTC) #3
Igor Sheludko
lgtm with nits: https://codereview.chromium.org/2175233003/diff/1/src/compiler/pipeline-statistics.h File src/compiler/pipeline-statistics.h (right): https://codereview.chromium.org/2175233003/diff/1/src/compiler/pipeline-statistics.h#newcode51 src/compiler/pipeline-statistics.h:51: bool InPhaseKind() { return !!phase_kind_stats_.scope_; } ...
4 years, 5 months ago (2016-07-25 09:58:10 UTC) #5
Benedikt Meurer
LGTM (rubber-stamped)
4 years, 5 months ago (2016-07-25 10:23:33 UTC) #6
jochen (gone - plz use gerrit)
https://codereview.chromium.org/2175233003/diff/1/src/compiler/pipeline-statistics.h File src/compiler/pipeline-statistics.h (right): https://codereview.chromium.org/2175233003/diff/1/src/compiler/pipeline-statistics.h#newcode51 src/compiler/pipeline-statistics.h:51: bool InPhaseKind() { return !!phase_kind_stats_.scope_; } On 2016/07/25 at ...
4 years, 5 months ago (2016-07-25 10:34:38 UTC) #7
Igor Sheludko
https://codereview.chromium.org/2175233003/diff/1/src/compiler/pipeline-statistics.h File src/compiler/pipeline-statistics.h (right): https://codereview.chromium.org/2175233003/diff/1/src/compiler/pipeline-statistics.h#newcode51 src/compiler/pipeline-statistics.h:51: bool InPhaseKind() { return !!phase_kind_stats_.scope_; } On 2016/07/25 10:34:38, ...
4 years, 5 months ago (2016-07-25 10:46:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175233003/1
4 years, 5 months ago (2016-07-25 10:47:37 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 11:12:48 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 11:14:39 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a6ccaf2684ff5972cb7a307c5270aa977c82483
Cr-Commit-Position: refs/heads/master@{#38009}

Powered by Google App Engine
This is Rietveld 408576698