Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 2175233002: Convert editing/inserting/insert-paragraph-0[1-5].html to use w3c test harness (Closed)

Created:
4 years, 5 months ago by yosin_UTC9
Modified:
4 years, 4 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/inserting/insert-paragraph-0[1-5].html to use w3c test harness This patch converts "editing/inserting/insert-paragraph-0[1-5].html" to use w3c test harness and consolidates into "insert_paragraph.html" to simplify test case for ease of maintenance. This patch is a preparation of getting rid of grammar checking feature. Committed: https://crrev.com/37238635dbb9c54c8034e9adad4371c6efe9a351 Cr-Commit-Position: refs/heads/master@{#407718}

Patch Set 1 : 2016-07-25T17:24:46 #

Patch Set 2 : 2016-07-26T13:41:23 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -398 lines) Patch
D third_party/WebKit/LayoutTests/editing/inserting/insert-paragraph-01.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/insert-paragraph-02.html View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/insert-paragraph-03.html View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/insert-paragraph-04.html View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/insert-paragraph-05.html View 1 chunk +0 lines, -13 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/inserting/insert_paragraph.html View 1 1 chunk +85 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-paragraph-01-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-paragraph-01-expected.txt View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-paragraph-02-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-paragraph-02-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-paragraph-03-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-paragraph-03-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-paragraph-05-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-paragraph-05-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-paragraph-01-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-paragraph-01-expected.txt View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-paragraph-02-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-paragraph-02-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-paragraph-03-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-paragraph-03-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-paragraph-05-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-paragraph-05-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-paragraph-01-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-paragraph-01-expected.txt View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-paragraph-02-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-paragraph-02-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-paragraph-03-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-paragraph-03-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-paragraph-05-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-paragraph-05-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
yosin_UTC9
PTAL
4 years, 5 months ago (2016-07-25 09:01:50 UTC) #7
yoichio
lgtm
4 years, 4 months ago (2016-07-26 01:56:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175233002/1
4 years, 4 months ago (2016-07-26 01:59:33 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/266148)
4 years, 4 months ago (2016-07-26 03:14:12 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175233002/1
4 years, 4 months ago (2016-07-26 04:09:15 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175233002/20001
4 years, 4 months ago (2016-07-26 04:44:41 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-26 05:50:36 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 05:52:43 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/37238635dbb9c54c8034e9adad4371c6efe9a351
Cr-Commit-Position: refs/heads/master@{#407718}

Powered by Google App Engine
This is Rietveld 408576698