Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 2175223003: ItemAdapter::clear() function needs to clear mDisabledEntries and mItemDescriptionMap (Closed)

Created:
4 years, 5 months ago by juncai
Modified:
4 years, 5 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ItemAdapter::clear() function needs to clear mDisabledEntries and mItemDescriptionMap At ItemChooserDialog.java, ItemAdapter::clear() is called when restart searching, and mDisabledEntries and mItemDescriptionMap store the information from previous search. So they need to be cleared. BUG=631099 Committed: https://crrev.com/44c624c2dfc6201fc0f60b717a6960767ff7e52a Cr-Commit-Position: refs/heads/master@{#407517}

Patch Set 1 : updated ItemAdapter::clear() function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
juncai
Please take a look.
4 years, 5 months ago (2016-07-25 17:13:07 UTC) #4
Ted C
lgtm
4 years, 5 months ago (2016-07-25 17:14:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175223003/1
4 years, 5 months ago (2016-07-25 18:10:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 18:14:26 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 18:18:33 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44c624c2dfc6201fc0f60b717a6960767ff7e52a
Cr-Commit-Position: refs/heads/master@{#407517}

Powered by Google App Engine
This is Rietveld 408576698