Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: src/d8-posix.cc

Issue 2175193003: Remove NaCl support. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/d8.cc ('k') | src/deoptimizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/d8-posix.cc
diff --git a/src/d8-posix.cc b/src/d8-posix.cc
index fb14f95f4269b0b2efb11350e8d5599c93307bf8..d2cf573d4c013207b62d0b35d4e68e89c24cb4bd 100644
--- a/src/d8-posix.cc
+++ b/src/d8-posix.cc
@@ -7,6 +7,7 @@
#include <signal.h>
#include <stdlib.h>
#include <string.h>
+#include <sys/select.h>
#include <sys/stat.h>
#include <sys/time.h>
#include <sys/types.h>
@@ -15,10 +16,6 @@
#include "src/d8.h"
-#if !V8_OS_NACL
-#include <sys/select.h>
-#endif
-
namespace v8 {
@@ -105,16 +102,11 @@ static bool WaitOnFD(int fd,
}
timeout.tv_usec = (read_timeout % 1000) * 1000;
timeout.tv_sec = read_timeout / 1000;
-#if V8_OS_NACL
- // PNaCL has no support for select.
- int number_of_fds_ready = -1;
-#else
int number_of_fds_ready = select(fd + 1,
&readfds,
&writefds,
&exceptfds,
read_timeout != -1 ? &timeout : NULL);
-#endif
return number_of_fds_ready == 1;
}
@@ -585,13 +577,8 @@ void Shell::SetUMask(const v8::FunctionCallbackInfo<v8::Value>& args) {
return;
}
if (args[0]->IsNumber()) {
-#if V8_OS_NACL
- // PNaCL has no support for umask.
- int previous = 0;
-#else
int previous = umask(
args[0]->Int32Value(args.GetIsolate()->GetCurrentContext()).FromJust());
-#endif
args.GetReturnValue().Set(previous);
return;
} else {
« no previous file with comments | « src/d8.cc ('k') | src/deoptimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698