Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2175193003: Remove NaCl support. (Closed)

Created:
4 years, 4 months ago by Yang
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove NaCl support. Committed: https://crrev.com/43ab247f56b2742214f848edc977e9bc3593bf2b Cr-Commit-Position: refs/heads/master@{#38081}

Patch Set 1 #

Patch Set 2 : fix gn build #

Patch Set 3 : revert accidental edit #

Patch Set 4 : also remove nacl from build files #

Patch Set 5 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -677 lines) Patch
M .gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Makefile View 1 2 3 10 chunks +3 lines, -42 lines 0 comments Download
D Makefile.nacl View 1 2 3 1 chunk +0 lines, -97 lines 0 comments Download
M gni/v8.gni View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M gypfiles/toolchain.gypi View 1 2 3 4 4 chunks +3 lines, -12 lines 0 comments Download
M gypfiles/vs_toolchain.py View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
M include/v8config.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/base/atomicops.h View 2 chunks +2 lines, -6 lines 0 comments Download
D src/base/atomicops_internals_portable.h View 1 chunk +0 lines, -138 lines 0 comments Download
M src/base/build_config.h View 1 chunk +0 lines, -15 lines 0 comments Download
M src/base/cpu.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M src/base/macros.h View 2 chunks +0 lines, -51 lines 0 comments Download
M src/base/platform/platform-aix.cc View 1 chunk +1 line, -6 lines 0 comments Download
M src/base/platform/platform-linux.cc View 5 chunks +2 lines, -32 lines 0 comments Download
M src/base/platform/platform-posix.cc View 7 chunks +1 line, -23 lines 0 comments Download
M src/base/platform/semaphore.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M src/base/sys-info.cc View 2 chunks +1 line, -4 lines 0 comments Download
M src/d8.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/d8-posix.cc View 4 chunks +1 line, -14 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/libsampler/sampler.cc View 6 chunks +3 lines, -13 lines 0 comments Download
M src/utils.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/v8.gyp View 1 2 3 2 chunks +6 lines, -15 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/base/sys-info-unittest.cc View 2 chunks +1 line, -8 lines 0 comments Download
D tools/nacl-run.py View 1 chunk +0 lines, -147 lines 0 comments Download

Messages

Total messages: 30 (23 generated)
Yang
4 years, 4 months ago (2016-07-25 12:59:14 UTC) #12
jochen (gone - plz use gerrit)
what about Makefile and Makefile.nacl?
4 years, 4 months ago (2016-07-25 15:01:52 UTC) #15
Yang
Thanks. I found some more occurrences and removed them too.
4 years, 4 months ago (2016-07-26 09:29:23 UTC) #18
jochen (gone - plz use gerrit)
lgtm
4 years, 4 months ago (2016-07-27 07:40:18 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175193003/80001
4 years, 4 months ago (2016-07-27 07:45:12 UTC) #27
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-07-27 07:47:20 UTC) #28
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 07:50:42 UTC) #30
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/43ab247f56b2742214f848edc977e9bc3593bf2b
Cr-Commit-Position: refs/heads/master@{#38081}

Powered by Google App Engine
This is Rietveld 408576698