ui/native_theme/native_theme_switches.h - Issue 2175163005: Add flag to hide scrollbars completely.

Side by Side Diff: ui/native_theme/native_theme_switches.h

Issue 2175163005: Add flag to hide scrollbars completely. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add tests for scrollbar behavior without animator. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/renderer/gpu/render_widget_compositor.cc ('K') | « content/renderer/gpu/render_widget_compositor.cc ('k') | ui/native_theme/native_theme_switches.cc » ('j') | ui/native_theme/native_theme_switches.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Defines all the command-line switches used by native theme	5 // Defines all the command-line switches used by native theme

6	6

7 #ifndef UI_NATIVE_THEME_NATIVE_THEME_SWITCHES_H_	7 #ifndef UI_NATIVE_THEME_NATIVE_THEME_SWITCHES_H_

8 #define UI_NATIVE_THEME_NATIVE_THEME_SWITCHES_H_	8 #define UI_NATIVE_THEME_NATIVE_THEME_SWITCHES_H_

9	9

10 #include "ui/native_theme/native_theme_export.h"	10 #include "ui/native_theme/native_theme_export.h"

11	11

12 namespace switches {	12 namespace switches {

13	13

14 NATIVE_THEME_EXPORT extern const char kDisableOverlayScrollbar[];	14 NATIVE_THEME_EXPORT extern const char kDisableOverlayScrollbar[];

15 NATIVE_THEME_EXPORT extern const char kEnableOverlayScrollbar[];	15 NATIVE_THEME_EXPORT extern const char kEnableOverlayScrollbar[];

	16 NATIVE_THEME_EXPORT extern const char kEnableHiddenScrollbar[];

16	17

17 } // namespace switches	18 } // namespace switches

18	19

19 namespace ui {	20 namespace ui {

20	21

21 NATIVE_THEME_EXPORT bool IsOverlayScrollbarEnabled();	22 NATIVE_THEME_EXPORT bool IsOverlayScrollbarEnabled();

	23 NATIVE_THEME_EXPORT bool IsHiddenScrollbarEnabled();
	sky 2016/08/02 20:30:24 AFAICT ui/native_theme doesn't handle this switch AFAICT ui/native_theme doesn't handle this switch at all, it's handled in content. Move the switch there? Eric Seckler 2016/08/03 17:34:54 It's used by IsOverlayScrollbarEnabled(), which is Show quoted text On 2016/08/02 20:30:24, sky wrote: > AFAICT ui/native_theme doesn't handle this switch at all, it's handled in > content. Move the switch there? It's used by IsOverlayScrollbarEnabled(), which is used in ui/native_theme. Would it thus be ok to leave it here? sky 2016/08/03 23:44:03 Does it need to be? It seems like the call sites c Show quoted text On 2016/08/03 17:34:54, Eric Seckler wrote: > On 2016/08/02 20:30:24, sky wrote: > > AFAICT ui/native_theme doesn't handle this switch at all, it's handled in > > content. Move the switch there? > > It's used by IsOverlayScrollbarEnabled(), which is used in ui/native_theme. > Would it thus be ok to leave it here? Does it need to be? It seems like the call sites check ShouldHideScrollbars() before checking IsOverlayScrollbarEnabled. Am I missing some calls that don't do that? Eric Seckler 2016/08/04 08:07:25 Yeah, there are quite a few other callsites of IsO Show quoted text On 2016/08/03 23:44:03, sky wrote: > On 2016/08/03 17:34:54, Eric Seckler wrote: > > On 2016/08/02 20:30:24, sky wrote: > > > AFAICT ui/native_theme doesn't handle this switch at all, it's handled in > > > content. Move the switch there? > > > > It's used by IsOverlayScrollbarEnabled(), which is used in ui/native_theme. > > Would it thus be ok to leave it here? > > Does it need to be? It seems like the call sites check ShouldHideScrollbars() > before checking IsOverlayScrollbarEnabled. Am I missing some calls that don't do > that? Yeah, there are quite a few other callsites of IsOverlayScrollbarEnabled(), see https://cs.chromium.org/search/?q=IsOverlayScrollbarEnabled&sq=package:chromi... (e.g. in NativeThemeAura and other places in content/). We need to make sure overlay scrollbars are enabled in order to hide them, otherwise the NO_ANIMATOR setting in RWC doesn't have any effect.
22	24

23 } // namespace ui	25 } // namespace ui

24	26

25 #endif // UI_NATIVE_THEME_NATIVE_THEME_SWITCHES_H_	27 #endif // UI_NATIVE_THEME_NATIVE_THEME_SWITCHES_H_

OLD	NEW