third_party/WebKit/LayoutTests/editing/inserting/insert-space.html - Issue 2175163004: Add a plain space instead of   between text nodes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/editing/inserting/insert-space.html

Issue 2175163004: Add a plain space instead of   between text nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use of assert_selection() and introduce |shouldEmitNBSPbeforeEnd| Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!doctype HTML>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script src="../assert_selection.js"></script>

	5 <script>

	6 test(() => assert_selection(

	7 '<div contenteditable><p>A\|B</p></div>',

	8 'insertText \ ',

	9 '<div contenteditable><p>A \|B</p></div>'),

	10 'insert a plain space in the middle of text node');

	11

	12 test(() => assert_selection(

	13 '<div contenteditable><p id="para"></p></div>',

	14 selection => {

	15 var para = selection.document.getElementById('para');

	16 para.appendChild(selection.document.createTextNode('A'));

	17 para.appendChild(selection.document.createTextNode('B'));

	18

	19 var range = selection.document.createRange();

	20 range.setStart(para.childNodes[0], 1);

	21 range.collapse(true);

	22 selection.removeAllRanges();

	23 selection.addRange(range);
	yosin_UTC9 2016/07/26 04:49:12 We don't need to use \|Range\|. We could write: sele We don't need to use \|Range\|. We could write: selection.collapse(para.firstChild, 1);
	24

	25 selection.document.execCommand('insertText', false, ' ');

	26 },

	27 '<div contenteditable><p id="para">A \|B</p></div>'),

	28 'insert a plain space between two inserted text nodes');

	29 </script>

OLD	NEW