Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2175133002:
Arithmetic xfermode stage. (Closed)
DescriptionArithmetic xfermode stage.
565 is identical, and as usual the old sRGB path was broken. :)
It was unimplemented, so the default missing Sk4f implementation was mimicking Src.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175133002
Committed: https://skia.googlesource.com/skia/+/05e3c39d93d2a41a78fd1a6ad13a9ea54e6bdbea
Patch Set 1 #Patch Set 2 : no clamp at all #Messages
Total messages: 19 (15 generated)
Description was changed from ========== Arithmetic xfermode stage. --config srgb looks different, 565 is identical. I suspect the old sRGB code was hitting the missing-Sk4f-implementation path, acting like a Src xfermode. BUG=skia: ========== to ========== Arithmetic xfermode stage. --config srgb looks different, 565 is identical. I suspect the old sRGB code was hitting the missing-Sk4f-implementation path, acting like a Src xfermode. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175133002 ==========
Description was changed from ========== Arithmetic xfermode stage. --config srgb looks different, 565 is identical. I suspect the old sRGB code was hitting the missing-Sk4f-implementation path, acting like a Src xfermode. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175133002 ========== to ========== Arithmetic xfermode stage. 565 is identical, and as usual the old sRGB path was broken. :) It was unimplemented, so the default missing Sk4f implementation was mimicking Src. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175133002 ==========
Patchset #2 (id:20001) has been deleted
Patchset #2 (id:40001) has been deleted
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
mtklein@chromium.org changed reviewers: + reed@google.com
Meant to land after https://codereview.chromium.org/2178793002, but it probably won't hurt if it lands first.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Arithmetic xfermode stage. 565 is identical, and as usual the old sRGB path was broken. :) It was unimplemented, so the default missing Sk4f implementation was mimicking Src. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175133002 ========== to ========== Arithmetic xfermode stage. 565 is identical, and as usual the old sRGB path was broken. :) It was unimplemented, so the default missing Sk4f implementation was mimicking Src. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175133002 Committed: https://skia.googlesource.com/skia/+/05e3c39d93d2a41a78fd1a6ad13a9ea54e6bdbea ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as https://skia.googlesource.com/skia/+/05e3c39d93d2a41a78fd1a6ad13a9ea54e6bdbea |
