Fix bot_update to correctly handle exceptions

Fix bot_update to correctly handle exceptions

If an exception occurs during a try block which prevents a step from actually executing, then the finally block's attempt to access step.active_result will fail, and the original exception will be hidden behind a new exception from the recipe engine. This CL changes this behavior so that the original exception will always fire.

Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/8697dfcf8b85fbad2cc8eee370063b5b4113eaeb

[martiniss, 2016-07-23 04:06:39]

Description was changed from

==========
Fix bot_update to correctly handle exceptions
==========

to

==========
Fix bot_update to correctly handle exceptions

If an exception occurs during a try block which prevents a step from actually
executing, then the finally block's attempt to access step.active_result will
fail, and the original exception will be hidden behind a new exception from the
recipe engine. This CL changes this behavior so that the original exception will
always fire.
==========

[martiniss, 2016-07-23 04:06:46]

martiniss@chromium.org changed reviewers:
+ iannucci@chromium.org, phajdan.jr@chromium.org

[martiniss, 2016-07-23 04:06:47]

PTAL

[nodir, 2016-07-23 04:10:09]

nodir@chromium.org changed reviewers:
+ nodir@chromium.org

[nodir, 2016-07-23 04:10:09]

lgtm

[martiniss, 2016-07-23 04:22:15]

The CQ bit was checked by martiniss@chromium.org

[martiniss, 2016-07-23 04:22:15]

The patchset sent to the CQ was uploaded after l-g-t-m from nodir@chromium.org
Link to the patchset: https://codereview.chromium.org/2175103002/#ps20001
(title: "Fix logic to correctly raise exception")

[commit-bot: I haz the power, 2016-07-23 04:22:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-23 04:25:00]

Description was changed from

==========
Fix bot_update to correctly handle exceptions

If an exception occurs during a try block which prevents a step from actually
executing, then the finally block's attempt to access step.active_result will
fail, and the original exception will be hidden behind a new exception from the
recipe engine. This CL changes this behavior so that the original exception will
always fire.
==========

to

==========
Fix bot_update to correctly handle exceptions

If an exception occurs during a try block which prevents a step from actually
executing, then the finally block's attempt to access step.active_result will
fail, and the original exception will be hidden behind a new exception from the
recipe engine. This CL changes this behavior so that the original exception will
always fire.

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/8697dfcf8b85fb...
==========

[commit-bot: I haz the power, 2016-07-23 04:25:01]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/8697dfcf8b85fb...