Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: scripts/slave/recipes/chromium_pgo.expected/full_tryserver_chromium_win_win_pgo.json

Issue 2175063002: Revert of Change PGO recipe to use MB now that it supports multiple phases. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: merge Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/recipes/chromium_pgo.expected/full_chromium_fyi_Chromium_Win_x64_PGO_Builder.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/chromium_pgo.expected/full_tryserver_chromium_win_win_pgo.json
diff --git a/scripts/slave/recipes/chromium_pgo.expected/full_tryserver_chromium_win_win_pgo.json b/scripts/slave/recipes/chromium_pgo.expected/full_tryserver_chromium_win_win_pgo.json
index 319f88ddea0387dcc30dd02839232e44eb789969..4be43a8c5e80e15a91c845dcecf147258c247f3f 100644
--- a/scripts/slave/recipes/chromium_pgo.expected/full_tryserver_chromium_win_win_pgo.json
+++ b/scripts/slave/recipes/chromium_pgo.expected/full_tryserver_chromium_win_win_pgo.json
@@ -157,24 +157,15 @@
"cmd": [
"python",
"-u",
- "[SLAVE_BUILD]\\src\\tools\\mb\\mb.py",
- "gen",
- "-m",
- "tryserver.chromium.win",
- "-b",
- "win_pgo",
- "--config-file",
- "[SLAVE_BUILD]\\src\\tools\\mb\\mb_config.pyl",
- "--phase",
- "1",
- "//out/Release"
+ "[SLAVE_BUILD]\\src\\build\\gyp_chromium.py"
],
- "cwd": "[SLAVE_BUILD]\\src",
"env": {
"GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-account-goma-client.json",
- "GYP_MSVS_VERSION": "2015"
+ "GYP_DEFINES": "buildtype=Official chrome_pgo_phase=1 component=static_library fastbuild=0 target_arch=ia32 use_goma=0",
+ "GYP_MSVS_VERSION": "2015",
+ "PATH": "[SLAVE_BUILD]\\src\\out\\Release;%(PATH)s"
},
- "name": "generate_build_files"
+ "name": "gyp_chromium"
},
{
"cmd": [
@@ -675,24 +666,14 @@
"cmd": [
"python",
"-u",
- "[SLAVE_BUILD]\\src\\tools\\mb\\mb.py",
- "gen",
- "-m",
- "tryserver.chromium.win",
- "-b",
- "win_pgo",
- "--config-file",
- "[SLAVE_BUILD]\\src\\tools\\mb\\mb_config.pyl",
- "--phase",
- "2",
- "//out/Release"
+ "[SLAVE_BUILD]\\src\\build\\gyp_chromium.py"
],
- "cwd": "[SLAVE_BUILD]\\src",
"env": {
"GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-account-goma-client.json",
+ "GYP_DEFINES": "buildtype=Official chrome_pgo_phase=2 component=static_library fastbuild=0 target_arch=ia32 use_goma=0",
"GYP_MSVS_VERSION": "2015"
},
- "name": "generate_build_files (2)"
+ "name": "gyp_chromium (2)"
},
{
"cmd": [
« no previous file with comments | « scripts/slave/recipes/chromium_pgo.expected/full_chromium_fyi_Chromium_Win_x64_PGO_Builder.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698