scripts/slave/recipe_modules/pgo/example.expected/full_chromium_pgo_test_Test_builder_benchmark_failure.json - Issue 2175063002: Revert of Change PGO recipe to use MB now that it supports multiple phases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/pgo/example.expected/full_chromium_pgo_test_Test_builder_benchmark_failure.json

Issue 2175063002: Revert of Change PGO recipe to use MB now that it supports multiple phases. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: merge Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/pgo/example.expected/full_chromium_pgo_test_Test_builder.json ('k') | scripts/slave/recipes/chromium_pgo.expected/full_chromium_fyi_Chromium_Win_PGO_Builder.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/pgo/example.expected/full_chromium_pgo_test_Test_builder_benchmark_failure.json

diff --git a/scripts/slave/recipe_modules/pgo/example.expected/full_chromium_pgo_test_Test_builder_benchmark_failure.json b/scripts/slave/recipe_modules/pgo/example.expected/full_chromium_pgo_test_Test_builder_benchmark_failure.json

index 7b8988505d487c4b72c52a279cfafb7dbf66ce3d..e52e16ef760a1e1fe468c500deac0bb76f6008e9 100644

--- a/scripts/slave/recipe_modules/pgo/example.expected/full_chromium_pgo_test_Test_builder_benchmark_failure.json

+++ b/scripts/slave/recipe_modules/pgo/example.expected/full_chromium_pgo_test_Test_builder_benchmark_failure.json

@@ -151,24 +151,15 @@

"cmd": [

"python",

"-u",

- "[SLAVE_BUILD]\\src\\tools\\mb\\mb.py",

- "gen",

- "-m",

- "chromium_pgo.test",

- "-b",

- "Test builder",

- "--config-file",

- "[SLAVE_BUILD]\\src\\tools\\mb\\mb_config.pyl",

- "--phase",

- "1",

- "//out/Release"

+ "[SLAVE_BUILD]\\src\\build\\gyp_chromium.py"

- "cwd": "[SLAVE_BUILD]\\src",

"env": {

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-account-goma-client.json",

- "GYP_MSVS_VERSION": "2015"

+ "GYP_DEFINES": "buildtype=Official chrome_pgo_phase=1 component=static_library fastbuild=0 target_arch=ia32 use_goma=0",

+ "GYP_MSVS_VERSION": "2015",

+ "PATH": "[SLAVE_BUILD]\\src\\out\\Release;%(PATH)s"

- "name": "generate_build_files"

+ "name": "gyp_chromium"

{

"cmd": [

@@ -671,24 +662,14 @@

"cmd": [

"python",

"-u",

- "[SLAVE_BUILD]\\src\\tools\\mb\\mb.py",

- "gen",

- "-m",

- "chromium_pgo.test",

- "-b",

- "Test builder",

- "--config-file",

- "[SLAVE_BUILD]\\src\\tools\\mb\\mb_config.pyl",

- "--phase",

- "2",

- "//out/Release"

+ "[SLAVE_BUILD]\\src\\build\\gyp_chromium.py"

- "cwd": "[SLAVE_BUILD]\\src",

"env": {

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-account-goma-client.json",

+ "GYP_DEFINES": "buildtype=Official chrome_pgo_phase=2 component=static_library fastbuild=0 target_arch=ia32 use_goma=0",

"GYP_MSVS_VERSION": "2015"

- "name": "generate_build_files (2)"

+ "name": "gyp_chromium (2)"

{

"cmd": [