[Findit] Fixing debug view UI not to bundle unclassified with reliable failures

appengine/findit/handlers/handlers_util.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from collections import defaultdict
 import copy
 
 from handlers import result_status
 from model import analysis_status
 from model.wf_analysis import WfAnalysis
@@ skipping 174 matching lines @@
     revision = culprit['revision']
     if organized_culprits.get(revision):
       organized_culprits[revision]['failed_tests'].append(test_name)
     else:
       organized_culprits[revision] = culprit
       organized_culprits[revision]['failed_tests'] = [test_name]
 
   return organized_culprits
 
 
-def _GetCulpritInfoForTryJobResultForTest(try_job_key, culprits_info,
-                                          show_debug_info):
+def _GetCulpritInfoForTryJobResultForTest(try_job_key, culprits_info):
   referred_build_keys = try_job_key.split('/')
   try_job = WfTryJob.Get(*referred_build_keys)
 
   if not try_job or try_job.compile_results:
     return
 
   try_job_result = try_job.test_results[-1] if try_job.test_results else None
 
   for step_try_jobs in culprits_info.values():
     # If try job found different culprits for each test, split tests by culprit.
     additional_tests_culprit_info = []
 
     for try_job_info in step_try_jobs['try_jobs']:
       if (try_job_key != try_job_info['try_job_key']
-          or (try_job_info.get('status') and not show_debug_info)):
+          or try_job_info.get('status')):
         # Conditions that try_job_info has status are:
         # If there is no swarming task, there won't be try job;
         # If the swarming task is not completed yet, there won't be try job yet;
         # If there are flaky tests found, those tests will be marked as flaky,
         # and no try job for them will be triggered.
-        # If a try job was force triggered by an admin.
         continue
 
       try_job_info['status'] = try_job.status
       if try_job_result:
         # Needs to use ref_name to match step_name in try job.
         ref_name = try_job_info['ref_name']
         # Saves try job information.
         if try_job_result.get('url'):  # pragma: no cover
           try_job_info['try_job_url'] = try_job_result['url']
           try_job_info['try_job_build_number'] = (
@@ skipping 72 matching lines @@
               'try_job_key': 'm/b/121'
           },
           ...
         ]
   """
   additional_flakiness_list = []
   for try_job in try_jobs:
     try_job_key = try_job['try_job_key']
     task = step_tasks_info.get('swarming_tasks', {}).get(try_job_key)
 
-    if (task['task_info']['status'] != analysis_status.COMPLETED and
-        not show_debug_info):
+    if task['task_info'].get('task_id'):
+      try_job['task_id'] = task['task_info']['task_id']
+      try_job['task_url'] = task['task_info']['task_url']
+
+    if (task['task_info']['status'] != analysis_status.COMPLETED):
       # There is someting wrong with swarming task or it's not done yet,
       # no try job yet or ever.
       try_job['status'] = result_status.NO_TRY_JOB_REASON_MAP[
           task['task_info']['status']]
       try_job['tests'] = task.get('all_tests', [])
+
+      if not show_debug_info:  
+        continue
+      else:
+        # TODO(lijeffrey): This is a hack to prevent unclassified failures
+        # from showing up as reliable in debug view . As part of the refactoring
+        # work categorizing failures and adding the ability to force trigger try
+        # jobs independently should be considered.
+        try_job['can_force'] = True
+    
+    # Swarming task is completed or a manual try job rerun was triggered.
+    # Group tests according to task result.
+    if task.get('ref_name'):
+      try_job['ref_name'] = task['ref_name']
     else:
-      # Swarming task is completed or a manual try job rerun was triggered.
-      # Group tests according to task result.
-      if task.get('ref_name'):
-        try_job['ref_name'] = task['ref_name']
-      else:
-        # A try job was forced for a non-swarming step.
-        if show_debug_info:  # pragma: no branch
-          try_job['ref_name'] = step_name.split()[0]
+      # A try job was forced for a non-swarming step.
+      if show_debug_info:  # pragma: no branch
+        try_job['ref_name'] = step_name.split()[0]
 
-      if task.get('reliable_tests'):
-        try_job['tests'] = task['reliable_tests']
-        if task.get('flaky_tests'):
-          # Split this try job into two groups: flaky group and reliable group.
-          flaky_try_job = copy.deepcopy(try_job)
-          flaky_try_job['status'] = result_status.FLAKY
-          flaky_try_job['tests'] = task['flaky_tests']
-          flaky_try_job['task_id'] = task['task_info']['task_id']
-          flaky_try_job['task_url'] = task['task_info']['task_url']
-          additional_flakiness_list.append(flaky_try_job)
-      elif task.get('flaky_tests'):  # pragma: no cover
-        # All Flaky.
-        try_job['status'] = result_status.FLAKY
-        try_job['tests'] = task['flaky_tests']
-
-    if task['task_info'].get('task_id'):
-      try_job['task_id'] = task['task_info']['task_id']
-      try_job['task_url'] = task['task_info']['task_url']
+    if task.get('reliable_tests'):
+      try_job['tests'] = task['reliable_tests']
+      if task.get('flaky_tests'):
+        # Split this try job into two groups: flaky group and reliable group.
+        flaky_try_job = copy.deepcopy(try_job)
+        flaky_try_job['status'] = result_status.FLAKY
+        flaky_try_job['tests'] = task['flaky_tests']
+        flaky_try_job['task_id'] = task['task_info']['task_id']
+        flaky_try_job['task_url'] = task['task_info']['task_url']
+        additional_flakiness_list.append(flaky_try_job)
+    elif task.get('flaky_tests'):  # pragma: no cover
+      # All Flaky.
+      try_job['status'] = result_status.FLAKY
+      try_job['tests'] = task['flaky_tests']
 
   try_jobs.extend(additional_flakiness_list)
 
 
 def _GetAllTryJobResultsForTest(failure_result_map, tasks_info,
                                 show_debug_info=False):
   culprits_info = defaultdict(lambda: defaultdict(list))
+
   if not tasks_info:
     return culprits_info
 
   try_job_keys = set()
 
   for step_name, step_failure_result_map in failure_result_map.iteritems():
     try_jobs = culprits_info[step_name]['try_jobs']
     if isinstance(step_failure_result_map, dict):
       step_try_job_keys = set()
       for try_job_key in step_failure_result_map.values():
@@ skipping 14 matching lines @@
 
       if show_debug_info:
         # Include any forced try jobs trigered manually in debug mode.
         try_job_keys.add(step_failure_result_map)
 
     _UpdateTryJobInfoBasedOnSwarming(tasks_info[step_name], try_jobs,
                                      show_debug_info,
                                      step_name)
 
   for try_job_key in try_job_keys:
-    _GetCulpritInfoForTryJobResultForTest(try_job_key, culprits_info,
-                                          show_debug_info)
+    _GetCulpritInfoForTryJobResultForTest(try_job_key, culprits_info)
+
   return culprits_info
 
 
 def _GetTryJobResultForCompile(failure_result_map):
   try_job_key = failure_result_map['compile']
   referred_build_keys = try_job_key.split('/')
   culprit_info = defaultdict(lambda: defaultdict(list))
 
   try_job = WfTryJob.Get(*referred_build_keys)
   if not try_job or try_job.test_results:
@@ skipping 48 matching lines @@
       culprits_info[step_name] = {
           'try_jobs': [
               {
                   'status': result_status.NO_FAILURE_RESULT_MAP,
                   'tests': tests
               }
           ]
       }
 
   return culprits_info