Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: gpu/command_buffer/build_gles2_cmd_buffer.py

Issue 2175043002: Add command buffer function glScheduleCALayerFilterEffectsCHROMIUM. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: blah nits. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/build_gles2_cmd_buffer.py
diff --git a/gpu/command_buffer/build_gles2_cmd_buffer.py b/gpu/command_buffer/build_gles2_cmd_buffer.py
index d12671c251483281e78d28f45963c8608fc5046f..815283ae4a228222cb38fd20de0bb64aa947b0e3 100755
--- a/gpu/command_buffer/build_gles2_cmd_buffer.py
+++ b/gpu/command_buffer/build_gles2_cmd_buffer.py
@@ -4425,6 +4425,16 @@ _FUNCTION_INFO = {
'extension': 'CHROMIUM_schedule_ca_layer',
'chromium': True,
},
+ 'ScheduleCALayerFilterEffectsCHROMIUM': {
+ 'type': 'PUTn',
+ 'count': 1,
+ 'impl_func': False,
+ 'client_test': False,
+ 'decoder_func': 'DoScheduleCALayerFilterEffectsCHROMIUM',
+ 'cmd_args': 'GLsizei count, const GLCALayerFilterEffect* effects',
+ 'extension': 'CHROMIUM_schedule_ca_layer',
+ 'chromium': True,
+ },
'ScheduleCALayerCHROMIUM': {
'type': 'Custom',
'impl_func': False,
@@ -7633,29 +7643,31 @@ TEST_P(%(test_name)s, %(name)sInvalidArgs%(arg_index)d_%(value_index)d) {
def WriteGLES2Implementation(self, func, f):
"""Overrriden from TypeHandler."""
- f.write("%s GLES2Implementation::%s(%s) {\n" %
- (func.return_type, func.original_name,
- func.MakeTypedOriginalArgString("")))
- f.write(" GPU_CLIENT_SINGLE_THREAD_CHECK();\n")
- func.WriteDestinationInitalizationValidation(f)
- self.WriteClientGLCallLog(func, f)
- last_pointer_name = func.GetLastOriginalPointerArg().name
- f.write(""" GPU_CLIENT_LOG_CODE_BLOCK({
- for (GLsizei i = 0; i < count; ++i) {
-""")
- values_str = ' << ", " << '.join(
- ["%s[%d + i * %d]" % (
- last_pointer_name, ndx, self.GetArrayCount(func)) for ndx in range(
- 0, self.GetArrayCount(func))])
- f.write(' GPU_CLIENT_LOG(" " << i << ": " << %s);\n' % values_str)
- f.write(" }\n });\n")
- for arg in func.GetOriginalArgs():
- arg.WriteClientSideValidationCode(f, func)
- f.write(" helper_->%sImmediate(%s);\n" %
- (func.name, func.MakeInitString("")))
- f.write(" CheckGLError();\n")
- f.write("}\n")
- f.write("\n")
+ impl_func = func.GetInfo('impl_func')
+ if impl_func == None or impl_func == True:
+ f.write("%s GLES2Implementation::%s(%s) {\n" %
+ (func.return_type, func.original_name,
+ func.MakeTypedOriginalArgString("")))
+ f.write(" GPU_CLIENT_SINGLE_THREAD_CHECK();\n")
+ func.WriteDestinationInitalizationValidation(f)
+ self.WriteClientGLCallLog(func, f)
+ last_pointer_name = func.GetLastOriginalPointerArg().name
+ f.write(""" GPU_CLIENT_LOG_CODE_BLOCK({
+ for (GLsizei i = 0; i < count; ++i) {
+ """)
+ values_str = ' << ", " << '.join(
+ ["%s[%d + i * %d]" % (
+ last_pointer_name, ndx, self.GetArrayCount(func)) for ndx in
+ range(0, self.GetArrayCount(func))])
+ f.write(' GPU_CLIENT_LOG(" " << i << ": " << %s);\n' % values_str)
+ f.write(" }\n });\n")
+ for arg in func.GetOriginalArgs():
+ arg.WriteClientSideValidationCode(f, func)
+ f.write(" helper_->%sImmediate(%s);\n" %
+ (func.name, func.MakeInitString("")))
+ f.write(" CheckGLError();\n")
+ f.write("}\n")
+ f.write("\n")
def WriteGLES2ImplementationUnitTest(self, func, f):
"""Writes the GLES2 Implemention unit test."""

Powered by Google App Engine
This is Rietveld 408576698