Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: src/parsing/parser-base.h

Issue 2175033002: [cleanup] Remove unused ExpressionClassifier args in ParserBase (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parsing/parser-base.h
diff --git a/src/parsing/parser-base.h b/src/parsing/parser-base.h
index 8a117554cf5e61c65aa039340b2262f92b732456..c9a7fa76b6eca3f7908347824fef1d92d5b5b949 100644
--- a/src/parsing/parser-base.h
+++ b/src/parsing/parser-base.h
@@ -1015,8 +1015,7 @@ class ParserBase : public Traits {
IdentifierT ParseIdentifierName(bool* ok);
- ExpressionT ParseRegExpLiteral(bool seen_equal,
- ExpressionClassifier* classifier, bool* ok);
+ ExpressionT ParseRegExpLiteral(bool seen_equal, bool* ok);
ExpressionT ParsePrimaryExpression(ExpressionClassifier* classifier,
bool* is_async, bool* ok);
@@ -1078,8 +1077,7 @@ class ParserBase : public Traits {
ExpressionT ParseTemplateLiteral(ExpressionT tag, int start,
ExpressionClassifier* classifier, bool* ok);
void AddTemplateExpression(ExpressionT);
- ExpressionT ParseSuperExpression(bool is_new,
- ExpressionClassifier* classifier, bool* ok);
+ ExpressionT ParseSuperExpression(bool is_new, bool* ok);
ExpressionT ParseNewTargetExpression(bool* ok);
void ParseFormalParameter(FormalParametersT* parameters,
@@ -1459,10 +1457,9 @@ ParserBase<Traits>::ParseIdentifierName(bool* ok) {
return name;
}
-
template <class Traits>
typename ParserBase<Traits>::ExpressionT ParserBase<Traits>::ParseRegExpLiteral(
- bool seen_equal, ExpressionClassifier* classifier, bool* ok) {
+ bool seen_equal, bool* ok) {
int pos = peek_position();
if (!scanner()->ScanRegExpPattern(seen_equal)) {
Next();
@@ -1558,12 +1555,12 @@ ParserBase<Traits>::ParsePrimaryExpression(ExpressionClassifier* classifier,
case Token::ASSIGN_DIV:
classifier->RecordBindingPatternError(
scanner()->peek_location(), MessageTemplate::kUnexpectedTokenRegExp);
- return this->ParseRegExpLiteral(true, classifier, ok);
+ return this->ParseRegExpLiteral(true, ok);
case Token::DIV:
classifier->RecordBindingPatternError(
scanner()->peek_location(), MessageTemplate::kUnexpectedTokenRegExp);
- return this->ParseRegExpLiteral(false, classifier, ok);
+ return this->ParseRegExpLiteral(false, ok);
case Token::LBRACK:
return this->ParseArrayLiteral(classifier, ok);
@@ -2953,7 +2950,7 @@ ParserBase<Traits>::ParseMemberWithNewPrefixesExpression(
ExpressionT result;
if (peek() == Token::SUPER) {
const bool is_new = true;
- result = ParseSuperExpression(is_new, classifier, CHECK_OK);
+ result = ParseSuperExpression(is_new, CHECK_OK);
} else if (peek() == Token::PERIOD) {
return ParseNewTargetExpression(CHECK_OK);
} else {
@@ -3044,7 +3041,7 @@ ParserBase<Traits>::ParseMemberExpression(ExpressionClassifier* classifier,
function_token_position, function_type, language_mode(), CHECK_OK);
} else if (peek() == Token::SUPER) {
const bool is_new = false;
- result = ParseSuperExpression(is_new, classifier, CHECK_OK);
+ result = ParseSuperExpression(is_new, CHECK_OK);
} else {
result = ParsePrimaryExpression(classifier, is_async, CHECK_OK);
}
@@ -3054,12 +3051,9 @@ ParserBase<Traits>::ParseMemberExpression(ExpressionClassifier* classifier,
return result;
}
-
template <class Traits>
typename ParserBase<Traits>::ExpressionT
-ParserBase<Traits>::ParseSuperExpression(bool is_new,
- ExpressionClassifier* classifier,
- bool* ok) {
+ParserBase<Traits>::ParseSuperExpression(bool is_new, bool* ok) {
Expect(Token::SUPER, CHECK_OK);
int pos = position();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698