Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 217503003: Add GL_ARB_invalidate_subdata functions to GrGLInterface. (Closed)

Created:
6 years, 9 months ago by bsalomon
Modified:
6 years, 8 months ago
Reviewers:
egdaniel
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add GL_ARB_invalidate_subdata functions to GrGLInterface. BUG=skia:1541 R=egdaniel@google.com Committed: https://code.google.com/p/skia/source/detail?r=14004

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : Fix compilation issues #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -4 lines) Patch
M include/gpu/gl/GrGLFunctions.h View 1 chunk +6 lines, -0 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 1 chunk +20 lines, -0 lines 0 comments Download
M src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp View 1 2 3 4 2 chunks +19 lines, -0 lines 0 comments Download
M src/gpu/gl/angle/GrGLCreateANGLEInterface.cpp View 2 chunks +15 lines, -4 lines 2 comments Download
M src/gpu/gl/iOS/GrGLCreateNativeInterface_iOS.cpp View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/gpu/gl/mac/GrGLCreateNativeInterface_mac.cpp View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
M src/gpu/gl/mesa/GrGLCreateMesaInterface.cpp View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M src/gpu/gl/unix/GrGLCreateNativeInterface_unix.cpp View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M src/gpu/gl/win/GrGLCreateNativeInterface_win.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
bsalomon
6 years, 9 months ago (2014-03-28 21:28:10 UTC) #1
egdaniel
lgtm w/ the one minor question https://codereview.chromium.org/217503003/diff/70001/src/gpu/gl/angle/GrGLCreateANGLEInterface.cpp File src/gpu/gl/angle/GrGLCreateANGLEInterface.cpp (right): https://codereview.chromium.org/217503003/diff/70001/src/gpu/gl/angle/GrGLCreateANGLEInterface.cpp#newcode91 src/gpu/gl/angle/GrGLCreateANGLEInterface.cpp:91: GET_PROC(GetStringi); What is ...
6 years, 8 months ago (2014-03-31 15:38:03 UTC) #2
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 8 months ago (2014-03-31 16:07:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/217503003/70001
6 years, 8 months ago (2014-03-31 16:07:59 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-31 16:08:00 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 8 months ago (2014-03-31 16:08:00 UTC) #6
bsalomon
https://codereview.chromium.org/217503003/diff/70001/src/gpu/gl/angle/GrGLCreateANGLEInterface.cpp File src/gpu/gl/angle/GrGLCreateANGLEInterface.cpp (right): https://codereview.chromium.org/217503003/diff/70001/src/gpu/gl/angle/GrGLCreateANGLEInterface.cpp#newcode91 src/gpu/gl/angle/GrGLCreateANGLEInterface.cpp:91: GET_PROC(GetStringi); On 2014/03/31 15:38:04, egdaniel wrote: > What is ...
6 years, 8 months ago (2014-04-01 13:01:29 UTC) #7
bsalomon
6 years, 8 months ago (2014-04-01 13:08:05 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 manually as r14004 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698