Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7093)

Unified Diff: chrome/browser/task_manager/task_manager.cc

Issue 2175003003: Use - in place of N/A for not-available values in Task Manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/app/generated_resources.grd ('K') | « chrome/app/generated_resources.grd ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/task_manager/task_manager.cc
diff --git a/chrome/browser/task_manager/task_manager.cc b/chrome/browser/task_manager/task_manager.cc
index ff300dec30f5c148ba9ddb46eea607e8fb3004c3..3e849ef338950ed58fa0a574920c56d26e2f86fa 100644
--- a/chrome/browser/task_manager/task_manager.cc
+++ b/chrome/browser/task_manager/task_manager.cc
@@ -77,6 +77,8 @@ class Profile;
namespace {
+const char kUnknownValueText[] = "-";
+
template <class T>
int ValueCompare(T value1, T value2) {
if (value1 < value2)
@@ -432,7 +434,7 @@ base::string16 TaskManagerModel::GetResourceNaClDebugStubPort(int index) const {
if (port == nacl::kGdbDebugStubPortUnknown) {
return base::ASCIIToUTF16("Unknown");
} else if (port == nacl::kGdbDebugStubPortUnused) {
- return base::ASCIIToUTF16("N/A");
+ return base::ASCIIToUTF16(kUnknownValueText);
} else {
return base::IntToString16(port);
}
@@ -464,14 +466,14 @@ base::string16 TaskManagerModel::GetResourceCPUUsage(int index) const {
base::string16 TaskManagerModel::GetResourcePrivateMemory(int index) const {
size_t private_mem;
if (!GetPrivateMemory(index, &private_mem))
- return base::ASCIIToUTF16("N/A");
+ return base::ASCIIToUTF16(kUnknownValueText);
return GetMemCellText(private_mem);
}
base::string16 TaskManagerModel::GetResourceSharedMemory(int index) const {
size_t shared_mem;
if (!GetSharedMemory(index, &shared_mem))
- return base::ASCIIToUTF16("N/A");
+ return base::ASCIIToUTF16(kUnknownValueText);
return GetMemCellText(shared_mem);
}
@@ -525,7 +527,7 @@ base::string16 TaskManagerModel::GetResourceVideoMemory(int index) const {
size_t video_memory;
bool has_duplicates;
if (!GetVideoMemory(index, &video_memory, &has_duplicates) || !video_memory)
- return base::ASCIIToUTF16("N/A");
+ return base::ASCIIToUTF16(kUnknownValueText);
if (has_duplicates) {
return GetMemCellText(video_memory) + base::ASCIIToUTF16("*");
}
« chrome/app/generated_resources.grd ('K') | « chrome/app/generated_resources.grd ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698